various tweaks and cleanups #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -460,10 +460,6 @@ private function addFlashMessageSection(ArrayNodeDefinition $rootNode) | |||
| ->defaultFalse() | |||
| ->info('Whether the cookie should only be transmitted over a secure HTTPS connection from the client.') | |||
| ->end() | |||
| ->scalarNode('httpOnly') | |||
There was a problem hiding this comment.
reading up on this again it simply makes no sense whatsoever to have a httpOnly cookie that is intended to be used in javascript. removed this option.
|
@ddeboer can you have a look here and if you agree merge it into your branch? |
Merged
| @@ -18,7 +18,7 @@ debug information when that header is present: | |||
| enabled | |||
| ------- | |||
|
|
|||
| **type**: ``enum`` **default**: ``auto`` **options**: ``true``, ``false``, ``auto`` | |||
| **type**: ``enum``, **default**: ``auto``, **options**: ``true``, ``false``, ``auto`` | |||
There was a problem hiding this comment.
Nitpicking: the Symfony docs have no commas here either.
There was a problem hiding this comment.
okay. i just felt it looks bad with the readthedocs theme we have.
|
removed the commas. imho its good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decided to do a PR against your PR so you can see what i am doing.