Remove custom Guzzle client docs from feature #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information seems too detailed to be shown in Features, so have it in Configuration only instead.
ddeboer
added a commit
that referenced
this pull request
Aug 14, 2014
Remove custom Guzzle client docs from feature
| with the caching proxy. If you need to customize the requests, for example to | ||
| send a basic authentication header, you can inject a custom Guzzle client:: | ||
| See the | ||
| :doc:`/reference/configuration/proxy-client#custom-guzzle-client` configuration reference. |
There was a problem hiding this comment.
i would have kept a .. tip:: here saying that if you need some headers on every request you should do a custom guzzle and link (with a :ref:, not the :doc: link). people reading here will just see "ah i can send some header, so lets just hardcode (or inject) that header everywhere i use the proxy client or cache manager"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information seems too detailed to be shown in Features, so have it in
Configuration only instead.