Enable PHP CS fixer on Scrutinizer #163
Conversation
| config: | ||
| standard: PSR2 | ||
|
|
||
| checks: |
There was a problem hiding this comment.
do we need to whitelist explicitly? seems a bit cumbersome, especially when new options are added we would need to add them here too...
There was a problem hiding this comment.
It seems adding checks is required if you want to add certain extra, but not all, checks. Scrutinizer now recommends this over configuring the separate tools.
|
i doubt that scrutinizer will change the contents of a PR. but it could discover issues we have. or we just run the phpcs occasionally on our codebase and commit the fixes. |
|
alright, then i am fine with this. we just go really down on the scrutinizer grade. can you squash these commits, then run fabpot/phpcsfixer and check scrutinizer if it still discovers things and check if we need to fix those too? btw, do you plan to do the same on the library? |
|
@ddeboer ping? |
Add checks Set phpcs to PSR2 Run php-cs-fixer
|
thanks. lots of cleanup! |
Noticed some CS errors. Does this help to fix them automatically?