Always load request_matcher and rule_matcher services #194
Conversation
| @@ -43,6 +43,7 @@ public function load(array $configs, ContainerBuilder $container) | |||
| $config = $this->processConfiguration($configuration, $configs); | |||
|
|
|||
| $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')); | |||
| $loader->load('matcher.xml'); | |||
There was a problem hiding this comment.
I now simply always load matcher.xml, which means rule_matcher and request_matcher will be loaded even if they are not used. I don’t find this a big problem. We could make their loading optional, for instance in the createRule|RequestMatcher() methods.
There was a problem hiding this comment.
the services being private, they will be removed when the container is built, so this should have 0 runtime impact
|
something goes wrong with the tests. or is that coming from an update in the library and has nothing to do with the PR? i don't see the connection... |
|
ping @ddeboer do we merge this one? |
|
No, I need to fix the tests first. They fail locally as well. |
|
now that you fixed tests in master, can you rebase this one? |
ddeboer
force-pushed
the
fix-request-matcher-service
branch
from
39ff00f to
624d9f4
Compare
|
Rebased. |
|
still one failing test, i think because configuration test is not adjusted. can you check please? |
These services where previously defined in cache_control_listener.xml. That file, however, was not loaded e.g. when only invalidation (and no cache control) rules were defined. This PR always load the request_matcher and rule_matcher, as they can be used for cache_control, invalidation and tags.
ddeboer
force-pushed
the
fix-request-matcher-service
branch
from
624d9f4 to
fd5db0a
Compare
|
Should be fixed now. |
…vice Always load request_matcher and rule_matcher services
Fix #193.
These services where previously defined in
cache_control_listener.xml. That file, however, was not loaded e.g. when only invalidation (and no cache control) rules were defined. This PR always load therequest_matcherandrule_matcher, so they can be used incache_control,invalidationand/ortags.