Skip to content

Updated Symfony HTTP cache docs #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Updated Symfony HTTP cache docs #295

merged 1 commit into from
Jul 1, 2016

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Jul 1, 2016

Warning about class caches in Symfony 2.8+.

Warning about class caches in Symfony 2.8+.
@dbu dbu merged commit 86ca33a into 1.3 Jul 1, 2016
@lsmith77 lsmith77 removed the wip/poc label Jul 1, 2016
@dbu
Copy link
Contributor Author

dbu commented Jul 1, 2016

thanks a lot @pestaa !

@dbu dbu deleted the pestaa-httpcache-docs branch July 1, 2016 13:16
@glye
Copy link

glye commented Aug 10, 2018

Hi @dbu & @pestaa! I'm trying the workaround of untagging the class cache warmer in a compiler pass. It is working per se, but still fails because Symfony's AddCacheWarmerPass runs before mine, so my untagging happens too late. Is it possible to preempt this? Many thanks for any help.

@glye
Copy link

glye commented Aug 10, 2018

Nevermind, I found a way: Instead of untagging the class cache warmer, I read the warmers already loaded by Symfony, filter out the warmer I don't want, and rewrite the list of warmers, like AddCacheWarmerPass does:
$container->getDefinition('cache_warmer')->replaceArgument(0, $warmers);
Feels a bit hackish, but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants