-
Notifications
You must be signed in to change notification settings - Fork 84
[1.x][Composer] Update dev dependencies to supported versions #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can also increase the memory limit, like https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/.travis.yml#L35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fails for all travis builds that are about older versions.
i consider 1.3 of this bundle to be in a mode where we only do very important security fixes but otherwise no updates anymore. if you can change the .travis.yml file so this builds again, thats a help - but i would want to leave composer.json alone. and if it keeps failing, i can live with that too, the 2.* version is whats relevant.
composer.json
Outdated
@@ -23,19 +23,19 @@ | |||
"require": { | |||
"php": "^5.4 || ^7.0", | |||
"friendsofsymfony/http-cache": "^1.4.5", | |||
"symfony/framework-bundle": "^2.3||^3.0" | |||
"symfony/framework-bundle": "^2.8||^3.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we should suddenly restrict dependencies of the maintenance version. instead, we can change the versions in the .travis.yml
file to only install more specific versions, that usually helps with the out of memory problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably safest. Then we can just adjust require-dev, it should be enough to fix it, on top of corresponding travis.yml changes.
ah sorry, the session listener hackery is part of the 1.3 version so thats why you wanted to fix that. i'll try the .travis.yml approach quickly. |
#471 was enough. i suggest we drop this. although i notice that composer.json allows far more versions than we actually test. but whatever, this is legacy code. |
Ok, well you know where to look once the issue comes back then ;) |
In order to get travis to not run out of memory on php 5: Update dependencies to supported versions, on dev dependencies even pick latests patch versions within all existing supported versions.
Todo: