Skip to content

[1.x][Composer] Update dev dependencies to supported versions #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Jun 28, 2018

In order to get travis to not run out of memory on php 5: Update dependencies to supported versions, on dev dependencies even pick latests patch versions within all existing supported versions.

Todo:

@XWB
Copy link
Member

XWB commented Jun 28, 2018

You can also increase the memory limit, like https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/.travis.yml#L35

@andrerom
Copy link
Contributor Author

andrerom commented Jun 28, 2018

True, but as amount of possible releases to resolve grow that might not be enough on PHP5 eventually again.

But that said, if I continue down the path here I'll need to remove tests for older symfony releases, so I realize I need some input from @dbu / @ddeboer / * here on what is preferred.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails for all travis builds that are about older versions.

i consider 1.3 of this bundle to be in a mode where we only do very important security fixes but otherwise no updates anymore. if you can change the .travis.yml file so this builds again, thats a help - but i would want to leave composer.json alone. and if it keeps failing, i can live with that too, the 2.* version is whats relevant.

composer.json Outdated
@@ -23,19 +23,19 @@
"require": {
"php": "^5.4 || ^7.0",
"friendsofsymfony/http-cache": "^1.4.5",
"symfony/framework-bundle": "^2.3||^3.0"
"symfony/framework-bundle": "^2.8||^3.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should suddenly restrict dependencies of the maintenance version. instead, we can change the versions in the .travis.yml file to only install more specific versions, that usually helps with the out of memory problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safest. Then we can just adjust require-dev, it should be enough to fix it, on top of corresponding travis.yml changes.

@dbu
Copy link
Contributor

dbu commented Jun 29, 2018

ah sorry, the session listener hackery is part of the 1.3 version so thats why you wanted to fix that. i'll try the .travis.yml approach quickly.

@andrerom andrerom changed the title [1.x][Composer] Update dependencies to supported versions [1.x][Composer] Update dev dependencies to supported versions Jun 29, 2018
@dbu
Copy link
Contributor

dbu commented Jun 29, 2018

#471 was enough. i suggest we drop this.

although i notice that composer.json allows far more versions than we actually test. but whatever, this is legacy code.

@andrerom
Copy link
Contributor Author

andrerom commented Jun 29, 2018

Ok, well you know where to look once the issue comes back then ;)

@andrerom andrerom closed this Jun 29, 2018
@andrerom andrerom deleted the patch-1 branch June 29, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants