-
Notifications
You must be signed in to change notification settings - Fork 84
Updated the bundle to use http-cache 2.5 #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry but I don't understand the issue with the dependencies. No idea what combination is wrong. |
we need to drop the test with lts 2: FOSHttpCacheBundle/.travis.yml Line 51 in 19e8057
the lowest version is probably that the monolog-bridge version 2.7 gets installed, according to the composer output, while we have the http-kernel at 3.4 and it does not have the logger interface. maybe we need to mark a conflict with monolog-brige < 3.0? |
Done but still... :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding the warning: onKernelResponse was only added to the session listener in 3.4.4: https://github.com/symfony/symfony/blob/v3.4.4/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php
i think we could theoretically just skip the whole listener on older symfony versions, but i doubt anybody wants to run 3.4.0-3 specifically. lets up the symfony dependencies to 3.4.4, okay?
composer.json
Outdated
@@ -52,7 +52,8 @@ | |||
"symfony/console": "To send invalidation requests from the command line" | |||
}, | |||
"conflict": { | |||
"twig/twig": "<1.12.0" | |||
"twig/twig": "<1.12.0", | |||
"symfony/monolog-bridge": "<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use 3.4 here to be in sync with the other symfony components?
Here we go 😄 |
thanks! |
No description provided.