Skip to content

Updated the bundle to use http-cache 2.5 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2018

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Sep 28, 2018

No description provided.

@Toflar
Copy link
Contributor Author

Toflar commented Sep 28, 2018

Sorry but I don't understand the issue with the dependencies. No idea what combination is wrong.

@dbu
Copy link
Contributor

dbu commented Sep 28, 2018

we need to drop the test with lts 2:

env: DEPENDENCIES="symfony/lts:^2"

the lowest version is probably that the monolog-bridge version 2.7 gets installed, according to the composer output, while we have the http-kernel at 3.4 and it does not have the logger interface. maybe we need to mark a conflict with monolog-brige < 3.0?

@Toflar
Copy link
Contributor Author

Toflar commented Sep 28, 2018

Done but still... :)

@dbu
Copy link
Contributor

dbu commented Sep 28, 2018

Downgrading symfony/monolog-bridge (v4.1.4 => v2.7.0): Loading from cache

the lowest version is probably that the monolog-bridge version 2.7 gets installed, according to the composer output, while we have the http-kernel at 3.4 and it does not have the logger interface. maybe we need to mark a conflict with monolog-brige < 3.0?

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the warning: onKernelResponse was only added to the session listener in 3.4.4: https://github.com/symfony/symfony/blob/v3.4.4/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php

symfony/symfony@f8727b8

i think we could theoretically just skip the whole listener on older symfony versions, but i doubt anybody wants to run 3.4.0-3 specifically. lets up the symfony dependencies to 3.4.4, okay?

composer.json Outdated
@@ -52,7 +52,8 @@
"symfony/console": "To send invalidation requests from the command line"
},
"conflict": {
"twig/twig": "<1.12.0"
"twig/twig": "<1.12.0",
"symfony/monolog-bridge": "<3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 3.4 here to be in sync with the other symfony components?

@Toflar
Copy link
Contributor Author

Toflar commented Oct 1, 2018

Here we go 😄

@dbu dbu merged commit 911bce4 into FriendsOfSymfony:master Oct 1, 2018
@dbu
Copy link
Contributor

dbu commented Oct 1, 2018

thanks!

@Toflar Toflar deleted the update-25 branch October 1, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants