Skip to content

Added link to symfony httpcache docs for http_method_override #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

alexander-schranz
Copy link
Contributor

Based on the symfony docs enable method override is enabled by default so we should also add Request:: enableHttpMethodParameterOverride() by default?

https://symfony.com/doc/current/reference/configuration/framework.html#http-method-override

@dbu
Copy link
Contributor

dbu commented Oct 23, 2018

this documentation only shows what to do different for using the in-process communication to invalidate cache. its no complete code example of how to set up the CacheKernel. we don't show the Request::createFromGlobals() line. therefore i think we should not explain this special case (though its weird that the config default is true, but you need to explicitly enable it in the front controller if you want to use it with the cache kernel).

in the intro to this chapter, we already link to https://symfony.com/doc/current/http_cache.html#symfony-reverse-proxy

i think what would make sense is to change "Now you need to adjust your front controller to use that cache instance rather than creating one:" to "Now you need to adjust your front controller (that you set up according to the Symfony HttpCache documentation_) to use that cache instance rather than creating one:"

@dbu
Copy link
Contributor

dbu commented Oct 23, 2018

do you agree that that would help?

@alexander-schranz alexander-schranz changed the title Added enable http method parameter override to docs Added link to symfony httpcache docs for http_method_override Oct 23, 2018
@@ -26,7 +26,7 @@ Event Dispatching HttpCache
~~~~~~~~~~~~~~~~~~~~~~~~~~~

You need to adjust your ``AppCache`` to support event handling and register the
cache event listeners for the functionality you want to use.
cache event listeners for the functionality you want to use.git st
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove this bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alexander-schranz
Copy link
Contributor Author

@dbu I aggree. Did change the text as you propose.

@dbu dbu merged commit ae2cf62 into FriendsOfSymfony:master Oct 23, 2018
@dbu
Copy link
Contributor

dbu commented Oct 23, 2018

thank you!

@alexander-schranz alexander-schranz deleted the patch-1 branch October 23, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants