Skip to content

Fix InvalidConfigurationException message after TagCapable support in logout_handler #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Fix InvalidConfigurationException message after TagCapable support in logout_handler #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d551985
Fix InvalidConfigurationException message after #486 change to TagCap…
andrerom Jul 29, 2019
2321966
Update Configuration.php
andrerom Jul 29, 2019
6389747
Adjust tests
andrerom Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function ($v) {
return $v;
}

throw new InvalidConfigurationException('To enable the user context logout handler, you need to configure a ban capable proxy_client.');
throw new InvalidConfigurationException('To enable the user context logout handler, you need to configure a tag capable proxy_client (varnish, symfony, noop or custom_proxy_client).');
})
->end()
// Determine the default tags header for the varnish client, depending on whether we use BAN or xkey
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/DependencyInjection/ConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,9 +608,9 @@ public function userContextLogoutHandlerProvider()
'auto no client' => ['config/user_context_auto_noclient.yml', false, false, false, false, null],
'auto ban client' => ['config/user_context_auto_banclient.yml', true, true, 'custom', 'auto', null],
'auto non ban client' => ['config/user_context_auto_notbanclient.yml', false, 'auto', 'nginx', 'auto', null],
'true no client' => ['config/user_context_true_noclient.yml', null, false, 'auto', false, 'you need to configure a ban capable proxy_client'],
'true no client' => ['config/user_context_true_noclient.yml', null, false, 'auto', false, 'you need to configure a tag capable proxy_client'],
'true ban client' => ['config/user_context_true_banclient.yml', true, true, 'custom', 'auto', null],
'true non ban client' => ['config/user_context_true_notbanclient.yml', null, true, 'nginx', 'auto', 'you need to configure a ban capable proxy_client'],
'true non ban client' => ['config/user_context_true_notbanclient.yml', null, true, 'nginx', 'auto', 'you need to configure a tag capable proxy_client'],
];
}

Expand Down