Skip to content

Adds compatibility with Twig 3.0 #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

Adds compatibility with Twig 3.0 #530

merged 1 commit into from
Nov 27, 2019

Conversation

jderusse
Copy link
Contributor

No description provided.

@jderusse jderusse force-pushed the patch-1 branch 2 times, most recently from fd1fceb to 3f46574 Compare November 27, 2019 10:16
dbu
dbu reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please make the twig extension backwards compatible so that we can still run with twig 2 for the time being.

@dbu dbu merged commit 2be2458 into FriendsOfSymfony:master Nov 27, 2019
@jderusse
Copy link
Contributor Author

errors were related to a change in $request->isMethodSafe which is deprecated.
But the fix is not as easy as I thougth, and is not related to that PR, so I reverted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @dbu