Fix CI Build and update PHPUnit

[alexander-schranz]

Locally I run into the following problem:

PHP Fatal error: Declaration of FOS\HttpCacheBundle\Tests\Unit\CacheManagerTest::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in ~/Sulu/sulu-develop.localhost/vendor/friendsofsymfony/http-cache-bundle/tests/Unit/CacheManagerTest.php on line 28

Fatal error: Declaration of FOS\HttpCacheBundle\Tests\Unit\CacheManagerTest::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in ~/Sulu/sulu-develop.localhost/vendor/friendsofsymfony/http-cache-bundle/tests/Unit/CacheManagerTest.php on line 28

This seems to be fixed by using:

<server name="SYMFONY_PHPUNIT_VERSION" value="6.5" />

Which seems to be set in the .travis.yml also. I think I would remove it there so it works locally also.

But then I run into the following error:

PHP Fatal error: Declaration of Mockery\Adapter\Phpunit\TestListener::endTest(PHPUnit\Framework\Test $test, float $time): void must be compatible with PHPUnit\Framework\TestListener::endTest(PHPUnit\Framework\Test $test, $time) in /Users/alexanderschranz/Documents/Sulu/sulu20-develop.localhost/vendor/friendsofsymfony/http-cache-bundle/vendor/mockery/mockery/library/Mockery/Adapter/Phpunit/TestListener.php on line 39

So I decided to update to PHPUnit 8. Which seems to fix this error.

[alexander-schranz]

@dbu any idea about the failing test?

[alexander-schranz]

Seems like a regression in: https://github.com/symfony/symfony/pull/36243/files#r465083756

[dbu]

lets wait until tomorrow if we get a reaction on for https://github.com/symfony/symfony/pull/36243/files#r465083756 and then either remove this again, or also add a check to the actual implementation to make people realize the handler does not work with symfony 5.1

[alexander-schranz]

Are you sure you want to throw an exception when the ContextInvalidationLogoutHandler class is used in Symfony 5.1? I'm little bit afraid doing that 🙈

[dbu]

i think its the correct thing to do. its not something we can silently work around, it simply does not work at all so devs need to be made aware if they did not check the changelog. better a clear error than a security issue that is silently sitting there.

[alexander-schranz]

Done in 853eaa0

[dbu]

some wording changes for the exception, otherwise i am happy with it

[dbu]

thanks a lot!