#643: Fix cache control expression Symfony DI configuration

[alongosz]

This PR fixes #643.

As described in #643, there are 2 issues with the current Extension configuration, when defined as follows:

fos_http_cache:
    cache_control:
        rules:
            - match:
                  host: ^login.example.com$
                  match_response: 'response.isFresh()'
                  expression_language: 'app.expression_language'
              headers:
                  cache_control: {public: false}

1. When using match_response option, we get the following Container compile-time error:

   Service "fos_http_cache.cache_control.expression.e4ac4270c49eeac61019bc369235175a": Cannot replace arguments for class "FOS\HttpCacheBundle\Http\ResponseMatcher\ExpressionResponseMatcher" if none have been configured yet.
   

2. When using match_response_expression_service, we get an error that such option doesn't exist for the Extension. Seems expression_language should be used (as the Extension Configuration would suggest).

In both cases fixed replaceArgument to be setArgument. The former way worked in Symfony 5, but doesn't work in Symfony 6+.

The 1st issue occurs only at compile-time, therefore existing Extension tests configuring match_response wouldn't surface the issue as the definition structure is correct. Seems Symfony now processes those differently at compile time.
I added testContainerCompilesWithCacheControlExpressionConfig which compiles the container and performs no other assertions. We can see the mentioned error on the current state of the 3.x branch when running that test.

There's no coverage for 2nd argument, so I added testConfigLoadCacheControlExpressionWithOverriddenExpressionLanguage test.

Side note: Alternatively, adding the above options to ./tests/Functional/Fixtures/app/config/config.yml config, would also uncover the bug when running any KernelTestCase test as those actually compile the container as well.

[dbu]

awesome, thanks a lot! i will update the changelog and tag a release

[dbu]

https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/3.1.2

[alongosz]

Thanks a lot @dbu 🙇 🎉

[dbu]

thank you for the fix!