replace Travis with GitHub actions and bump dependencies (#414)

* feat: add github actions (replace travis)

* feat: add github actions (replace travis)

* feat: add github actions (replace travis)

* Add JS tests to Github actions

* Add return types to fix deprecations

* Use SF 5.4 for actions

Co-authored-by: Tobias Feijten <[email protected]>

Author: Chris53897

.github/workflows/code_checks.yaml

@@ -0,0 +1,97 @@
+# .github/workflows/code_checks.yaml
+name: Code_Checks
+
+on: ["push", "pull_request"]
+
+jobs:
+  js-tests:
+    name: "JS Tests"
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install JS dependencies
+        run: |
+          cd Resources && npm install
+
+      - name: Run JS tests
+        run: |
+          cd Resources && npm run test
+  phpunit:
+    name: "PHP ${{ matrix.php }} + ${{ matrix.dependencies }} dependencies + Symfony ${{ matrix.symfony }}"
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.1', '7.2', '7.3', '7.4', '8.0']
+        dependencies: [highest]
+        symfony: ['*']
+        include:
+          # Minimum supported dependencies with the oldest supported PHP version
+          - php: '7.1'
+            dependencies: lowest
+            symfony: '*'
+
+          # Minimum supported dependencies with the latest supported PHP version
+          - php: '8.0'
+            dependencies: lowest
+            symfony: '*'
+
+          - php: '8.0'
+            dependencies: highest
+            symfony: '*'
+
+          # Test each supported Symfony version with lowest supported PHP version
+          - php: '7.1'
+            dependencies: highest
+            symfony: '3.4.*'
+
+          - php: '7.1'
+            dependencies: highest
+            symfony: '4.4.*'
+
+          - php: '7.2'
+            dependencies: highest
+            symfony: '5.4.*'
+
+          - php: '7.3'
+            dependencies: highest
+            symfony: '5.4.*'
+
+          - php: '7.4'
+            dependencies: highest
+            symfony: '5.4.*'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - name: Require Symfony version
+        if: matrix.symfony != '*'
+        run: |
+          composer global require --no-interaction --no-progress symfony/flex:^1.11
+          composer config extra.symfony.require ${{ matrix.symfony }}
+
+      - name: Update project dependencies
+        uses: ramsey/composer-install@v1
+        with:
+          dependency-versions: ${{ matrix.dependencies }}
+
+      - name: Cache PHPUnit
+        uses: actions/cache@v2
+        with:
+          path: vendor/bin/.phpunit
+          key: ${{ runner.os }}-phpunit-${{ matrix.php }}
+
+      - name: Install PHPUnit
+        run: vendor/bin/simple-phpunit install
+
+      - name: Run PHPUnit tests
+        env:
+          SYMFONY_DEPRECATIONS_HELPER: max[self]=0
+        run: vendor/bin/simple-phpunit -v

.travis.yml

@@ -106,7 +106,7 @@ protected function configure()
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         if(!in_array($input->getOption('format'), array('js', 'json'))) {
             $output->writeln('<error>Invalid format specified. Use js or json.</error>');

Command/DumpCommand.php

@@ -76,7 +76,7 @@ protected function configure()
     /**
      * @see Command
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         if ($name = $input->getArgument('name')) {
             /** @var Route $route */

Command/RouterDebugExposedCommand.php

@@ -19,6 +19,7 @@ class RouteCollectionDenormalizer implements DenormalizerInterface
 {
     /**
      * {@inheritDoc}
+     * @return mixed
      */
     public function denormalize($data, $class, $format = null, array $context = array())
     {
@@ -43,7 +44,7 @@ public function denormalize($data, $class, $format = null, array $context = arra
     /**
      * {@inheritDoc}
      */
-    public function supportsDenormalization($data, $type, $format = null)
+    public function supportsDenormalization($data, $type, $format = null): bool
     {
         if (!is_array($data)) {
             return false;

Serializer/Denormalizer/RouteCollectionDenormalizer.php

@@ -21,6 +21,7 @@ class RouteCollectionNormalizer implements NormalizerInterface
 {
     /**
      * {@inheritDoc}
+     * @return array|string|int|float|bool|\ArrayObject|null
      */
     public function normalize($data, $format = null, array $context = array())
     {
@@ -45,7 +46,7 @@ public function normalize($data, $format = null, array $context = array())
     /**
      * {@inheritDoc}
      */
-    public function supportsNormalization($data, $format = null)
+    public function supportsNormalization($data, $format = null): bool
     {
         return $data instanceof RouteCollection;
     }

Serializer/Normalizer/RouteCollectionNormalizer.php

@@ -21,6 +21,7 @@ class RoutesResponseNormalizer implements NormalizerInterface
 {
     /**
      * {@inheritdoc}
+     * @return array|string|int|float|bool|\ArrayObject|null
      */
     public function normalize($data, $format = null, array $context = array())
     {
@@ -38,7 +39,7 @@ public function normalize($data, $format = null, array $context = array())
     /**
      * {@inheritDoc}
      */
-    public function supportsNormalization($data, $format = null)
+    public function supportsNormalization($data, $format = null): bool
     {
         return $data instanceof RoutesResponse;
     }

Serializer/Normalizer/RoutesResponseNormalizer.php

@@ -17,14 +17,14 @@
     ],
     "require": {
         "php": "^7.1|^8.0",
-        "symfony/framework-bundle": "~3.3|^4.0|^5.0",
-        "symfony/serializer": "~3.3|^4.0|^5.0",
-        "symfony/console": "~3.3|^4.0|^5.0",
-        "willdurand/jsonp-callback-validator": "~1.0"
+        "symfony/framework-bundle": "~3.4|^4.4.20|^5.0",
+        "symfony/serializer": "~3.4|^4.4.20|^5.0",
+        "symfony/console": "~3.4|^4.4.20|^5.0",
+        "willdurand/jsonp-callback-validator": "~1.1"
     },
     "require-dev": {
-        "symfony/expression-language": "~3.3|^4.0|^5.0",
-        "symfony/phpunit-bridge": "^5.1"
+        "symfony/expression-language": "~3.4|^4.4.20|^5.0",
+        "symfony/phpunit-bridge": "^5.3"
     },
     "autoload": {
         "psr-4": { "FOS\\JsRoutingBundle\\": "" },