-
Notifications
You must be signed in to change notification settings - Fork 20
Java: Use the models packs in the query pack and promote experimental models. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so added in the wrong qlpack).
d5ec5da
to
6b1a690
Compare
pwntester
approved these changes
Nov 25, 2024
Thanks @michaelnebel What were all those |
That was a way of "activating" (only include specific) experimental Models as Data models for a given query. Since the experimental models are converted to "ordinary" models (which means that they also apply to all queries), we no longer need to "activate" anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we
DCA was used to check that this didn't cause any massive discrepancies: https://github.com/github/codeql-dca-main/issues/24959
The experiment shows no changes in alerts or performance.
For the curious reader, here are the tuple counts for the queries in the default query suite for the java DCA projects: https://github.com/github/codeql-dca-main/blob/data/michaelnebel/auto/community-pack/e876bc7/1732286194857/reports/summaries/csv/Query_result_tuple_counts.csv
The experiment was started using the DCA command (for this to be reproducible https://github.com/github/codeql-dca/pull/2324 needs to be merged):