Skip to content

Java: Use the models packs in the query pack and promote experimental models. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 25, 2024

Conversation

michaelnebel
Copy link
Collaborator

@michaelnebel michaelnebel commented Nov 22, 2024

In this PR we

  • Update the Java dependencies
  • Apply the Java models in the model packs to the queries in the java query pack.
  • Promote experimental models to production models (note that I have not reviewed the accuracy of these).

DCA was used to check that this didn't cause any massive discrepancies: https://github.com/github/codeql-dca-main/issues/24959
The experiment shows no changes in alerts or performance.
For the curious reader, here are the tuple counts for the queries in the default query suite for the java DCA projects: https://github.com/github/codeql-dca-main/blob/data/michaelnebel/auto/community-pack/e876bc7/1732286194857/reports/summaries/csv/Query_result_tuple_counts.csv

The experiment was started using the DCA command (for this to be reproducible https://github.com/github/codeql-dca/pull/2324 needs to be merged):

./dca generate --language java 416266523758ea327e414257e07fe5e0e1b8fd48@00ea65f151921841cfb5a102959fc867c41e3502 416266523758ea327e414257e07fe5e0e1b8fd48@6dd34ce0f226d96652fa9ef748ec9f2b1cca43eb --extra-config-file dca-configs/community-packs.yml

@michaelnebel michaelnebel changed the title Java: Use the distributed models packs in the query pack and promote experimental models. Java: Use the models packs in the query pack and promote experimental models. Nov 22, 2024
@michaelnebel michaelnebel marked this pull request as ready for review November 25, 2024 07:42
@pwntester
Copy link

Thanks @michaelnebel What were all those ActivateXXX classes for?

@michaelnebel
Copy link
Collaborator Author

Thanks @michaelnebel What were all those ActivateXXX classes for?

That was a way of "activating" (only include specific) experimental Models as Data models for a given query. Since the experimental models are converted to "ordinary" models (which means that they also apply to all queries), we no longer need to "activate" anything.

@michaelnebel michaelnebel merged commit 01d7bee into main Nov 25, 2024
13 checks passed
@michaelnebel michaelnebel deleted the java/promotemodels branch November 25, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants