Skip to content

Java: Remove dependency to the CodeQL java query pack. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

michaelnebel
Copy link
Collaborator

@michaelnebel michaelnebel commented Dec 17, 2024

In this PR we

  • Remove the dependency to the CodeQL java query pack (we needed to add an experimental library for the CodeQL repo, which I missed the first time around as it wasn't stored in the experimental folder).
  • Add a test for the decompression bomb query <-- This test was originally named test.ql and files with that name are explicitly "ignored" in the .gitignore file.

@michaelnebel michaelnebel force-pushed the java/removequerysuitedependecy branch 2 times, most recently from 19414bc to a66cc33 Compare December 18, 2024 13:47
@michaelnebel michaelnebel force-pushed the java/removequerysuitedependecy branch from a66cc33 to 09a70a7 Compare December 19, 2024 08:23
@michaelnebel michaelnebel marked this pull request as ready for review December 19, 2024 09:09
Copy link
Contributor

@GeekMasher GeekMasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelnebel michaelnebel merged commit 7a6a715 into main Dec 20, 2024
13 checks passed
@michaelnebel michaelnebel deleted the java/removequerysuitedependecy branch December 20, 2024 11:22
@98629437540
Copy link

Estou vendo boas é algo melhor obrigado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants