-
-
Notifications
You must be signed in to change notification settings - Fork 455
[11.9] Add support for Advanced Search API #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Gitlab API library. | ||
* | ||
* (c) Matt Humphrey <[email protected]> | ||
* (c) Graham Campbell <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gitlab\Api; | ||
|
||
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException; | ||
use Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException; | ||
use Symfony\Component\OptionsResolver\Options; | ||
|
||
class Search extends AbstractApi | ||
{ | ||
/** | ||
* @param array $parameters { | ||
* | ||
* @var string $scope The scope to search in | ||
* @var string $search The search query | ||
* @var string $state Filter by state. Issues and merge requests are supported; it is ignored for other scopes. | ||
* @var bool $confidential Filter by confidentiality. Issues scope is supported; it is ignored for other scopes. | ||
* @var string $order_by Allowed values are created_at only. If this is not set, the results are either sorted by created_at in descending order for basic search, or by the most relevant documents when using advanced search. | ||
* @var string $sort Return projects sorted in asc or desc order (default is desc) | ||
* } | ||
* | ||
* @throws UndefinedOptionsException If an option name is undefined | ||
* @throws InvalidOptionsException If an option doesn't fulfill the | ||
* specified validation rules | ||
* | ||
* @return mixed | ||
*/ | ||
public function all(array $parameters = []) | ||
{ | ||
$resolver = $this->createOptionsResolver(); | ||
$booleanNormalizer = function (Options $resolver, $value): string { | ||
return $value ? 'true' : 'false'; | ||
}; | ||
$resolver->setDefined('confidential') | ||
->setAllowedTypes('confidential', 'bool') | ||
->setNormalizer('confidential', $booleanNormalizer); | ||
$scope = [ | ||
'projects', | ||
'issues', | ||
'merge_requests', | ||
'milestones', | ||
'snippet_titles', | ||
'users', | ||
]; | ||
$resolver->setDefined('scope') | ||
->setAllowedValues('scope', $scope); | ||
$resolver->setDefined('search'); | ||
$resolver->setDefined('order_by') | ||
->setAllowedValues('order_by', ['created_at']); | ||
$resolver->setDefined('sort') | ||
->setAllowedValues('sort', ['asc', 'desc']); | ||
|
||
return $this->get('search', $resolver->resolve($parameters)); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Gitlab API library. | ||
* | ||
* (c) Matt Humphrey <[email protected]> | ||
* (c) Graham Campbell <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gitlab\Tests\Api; | ||
|
||
use Gitlab\Api\Search; | ||
|
||
class SearchTest extends TestCase | ||
{ | ||
/** | ||
* @test | ||
*/ | ||
public function shouldGetAll(): void | ||
{ | ||
$expectedArray = [ | ||
['id' => 6, 'name' => 'Project 6 bla'], | ||
['id' => 7, 'name' => 'Project 7 bla'], | ||
['id' => 8, 'name' => 'Project 8 bla'], | ||
]; | ||
|
||
$api = $this->getApiMock(); | ||
$api->expects($this->once()) | ||
->method('get') | ||
->with('search', [ | ||
'scope' => 'projects', | ||
'confidential' => 'false', | ||
'search' => 'bla', | ||
'order_by' => 'created_at', | ||
'sort' => 'desc', | ||
]) | ||
->will($this->returnValue($expectedArray)); | ||
|
||
$this->assertEquals($expectedArray, $api->all([ | ||
'scope' => 'projects', | ||
'confidential' => false, | ||
'search' => 'bla', | ||
'order_by' => 'created_at', | ||
'sort' => 'desc', | ||
])); | ||
} | ||
|
||
protected function getApiClass() | ||
{ | ||
return Search::class; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are not intentionally not supported. Please remove them. You need to use the result pager class.