This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Added extensions methods #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var actualValue = input.IsPullRequest(); | ||
|
|
||
| Assert.AreEqual(expectedValue, actualValue); |
There was a problem hiding this comment.
I'm quite a fan of Shouldly for assertions. input.IsPullRequest().ShouldBe(expectedValue) will give quite good error messages.
There was a problem hiding this comment.
I'll give you this one. It's all a matter of preference, to be honest I think nunit provides really good feedback (I expected x, but got y). Not sure how shouldly does it but I'll do it anyway.
There was a problem hiding this comment.
Shouldly actually grabs the source code from your code to use in the assertion. It should give better error messages in all cases :)
|
@JakeGinnivan All changes I think should be made are made. |
|
Nice! |
asbjornu
added a commit
to asbjornu/GitTools.Core
that referenced
this pull request
Apr 20, 2016
Supress CS0414: The private field 'field' is assigned but its value is never used. Supress CS1701: Assuming assembly reference "Assembly Name GitTools#1" matches "Assembly Name GitTools#2", you may need to supply runtime policy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.