Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

#18 Support GitLink #20

Merged
merged 1 commit into from
Nov 12, 2015
Merged

#18 Support GitLink #20

merged 1 commit into from
Nov 12, 2015

Conversation

GeertvanHorrik
Copy link
Contributor

No description provided.

@GeertvanHorrik GeertvanHorrik self-assigned this Nov 12, 2015
GeertvanHorrik added a commit that referenced this pull request Nov 12, 2015
@GeertvanHorrik GeertvanHorrik merged commit 338e491 into master Nov 12, 2015
@gep13
Copy link
Member

gep13 commented Nov 13, 2015

So this is something that I never really understood was required. So in order for GitLink to function, you need to run the exe against the source code, is that correct?

I have recently submitted PR's into Cake to get native support for GitVersion, GitReleaseNotes, and GitReleaseManager in their tooling, you can find it here:

http://cakebuild.net/dsl

Does it make sense to do the same for GitLink?

@GeertvanHorrik
Copy link
Contributor Author

It only makes sense if you want to be able to step through the cakebuild code. So GitLink is really useful when you want to use "step into" for other libs. For example when I am developing GitReleaseNotes, I want to be able to step into GitTools.Core and GitTools.IssueTrackers.

@gep13
Copy link
Member

gep13 commented Nov 13, 2015

Cake is a build system, so wasn't planning on using GitLink directly, but rather, providing the ability for people using Cake as their Build System, to then call GitLink on their project.

Something like:

Task("Run-GitLink")
    .Does(() =>
{
    GitLink(new GitLinkSettings {
        UserName = "https://github.com/gittools/gittools.core",
        Branch = EnvironmentVariable("APPVEYOR_REPO_BRANCH"),
        Source = EnvironmentVariable("APPVEYOR_REPO_COMMIT"),
        FileName = "src/GitTools.Core.sln"
    });
});

In the same way that you can call GitVersion currently: http://cakebuild.net/api/cake.common.tools.gitversion/84dbc5a7/73d63de7

@GeertvanHorrik
Copy link
Contributor Author

That is really nice. But don't use that username ;-)

@GeertvanHorrik
Copy link
Contributor Author

But to explain:

  1. Run GitLink against soruce files
  2. Include pdbs in nuspec

Now I think about it, I might have forgotten 2

@gep13
Copy link
Member

gep13 commented Nov 13, 2015

@GeertvanHorrik said...
That is really nice. But don't use that username ;-)

I was guessing at what the -u parameter was.

@GeertvanHorrik
Copy link
Contributor Author

It stands for url. It doesn't make sense to have authentication (it's not supported by source servers (or the clients)).

@gep13
Copy link
Member

gep13 commented Nov 13, 2015

Yip, that makes perfect sense, in which case, I think GitLink would be a nice addition into the Cake Common Tooling, and can sit beside GitVersion, GitReleaseNotes, and GitReleaseManager 😄

@gep13
Copy link
Member

gep13 commented Nov 13, 2015

@GeertvanHorrik said...
It stands for url. It doesn't make sense to have authentication (it's not supported by source servers (or the clients)).

Ah, that makes sense 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants