This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Migration to replace GitPreparer by GitRepositoryFactory #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to check how much of the GitRepositoryHelper can be deleted from the core. |
GeertvanHorrik
added a commit
that referenced
this pull request
Dec 4, 2015
Migration to replace GitPreparer by GitRepositoryFactory
| @@ -6,51 +6,62 @@ namespace GitTools.Git | |||
| using LibGit2Sharp; | |||
| using Logging; | |||
|
|
|||
| public class GitPreparer | |||
| public static class GitRepositoryFactory | |||
There was a problem hiding this comment.
Am just having a play with this now, I think this only works for dynamic repositories? A non-dynamic repo will never get normalised?
Also does noFetch make sense for dynamic repos?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JakeGinnivan can you check the first changes?