Skip to content

Move GitVersionTask into build directory #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

twsouthwick
Copy link
Contributor

The current layout of the nupkg the task comes in causes problems in some variations of project.json (see description in #1040). This moves all the related build tools into the build/ folder and removes target specific folders (since they don't add anything special).

Fixes #1040

@JakeGinnivan
Copy link
Contributor

Nice change!

@JakeGinnivan JakeGinnivan merged commit a61138a into GitTools:master Sep 20, 2016
@JakeGinnivan
Copy link
Contributor

FYI this will only be available in the v4 betas.

@twsouthwick twsouthwick deleted the nupkg-move branch September 20, 2016 15:42
@tapvirvirk
Copy link

Hi,

I'm trying the same and getting the below error ,
Restoring packages for C:\project.json...
GitVersionTask 4.0.0-beta0007 is not compatible with .NETFramework,Version=v4.5.
Some packages are not compatible with .NETFramework,Version=v4.5.
GitVersionTask 4.0.0-beta0007 is not compatible with .NETFramework,Version=v4.5 (win).
Some packages are not compatible with .NETFramework,Version=v4.5 (win).
GitVersionTask 4.0.0-beta0007 is not compatible with .NETFramework,Version=v4.5 (win-x64).
Some packages are not compatible with .NETFramework,Version=v4.5 (win-x64).
GitVersionTask 4.0.0-beta0007 is not compatible with .NETFramework,Version=v4.5 (win-x86).
Some packages are not compatible with .NETFramework,Version=v4.5 (win-x86).

My project.json file looks like below,
{

"frameworks": {

"net452": {
  "imports": "portable-net+sl+win+wpa+wp"
}

},
"runtimes": {
"win": {},
"win-x86": {},
"win-x64": {}
},
"dependencies": {
"AWSSDK.Core": "3.3.0.2",
"AWSSDK.S3": "3.3.0.1",
"log4net": "2.0.5",
"GitVersionTask" : "4.0.0-beta0007"
}
}
Can you please help me out in retoring the GitVersionTask using project.json?

@twsouthwick
Copy link
Contributor Author

I saw the error originally with beta0007, so you'll have to wait until the next beta is available

@tapvirvirk
Copy link

tapvirvirk commented Oct 5, 2016

Thanks for the quick update. Will you let me know the tentative date of the next beta/stable release?

@twsouthwick
Copy link
Contributor Author

That would be a question for @JakeGinnivan

@tapvirvirk
Copy link

@JakeGinnivan - Will you please confirm on the next stable or Beta release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants