Skip to content

Update version-increments.md #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Conversation

Wesley-Lomax
Copy link
Contributor

Added space to examples for minor, patch and fix as required for the regex

Add space to examples for minor, patch and fix as required for the regex
@pascalberger
Copy link
Member

Thanks for the PR!

I never used this feature, but shouldn't this also work without the whitespaces according to this test case? Anyone knows how this was intended to work?

Otherwise I would suggest to fix the code to allow whitespaces instead.

@asbjornu
Copy link
Member

Since +semver: breaking, +semver: major and +semver: feature are with a space, it makes sense for consistency to add a space to +semver:minor, +semver:patch and +semver:fix as well. I do agree the code should allow both, though.

@Wesley-Lomax
Copy link
Contributor Author

Wesley-Lomax commented Sep 26, 2016

They are shown with a space here as well - configuration

Would be good to have it work with and without the space though.

@JakeGinnivan
Copy link
Contributor

@JakeGinnivan JakeGinnivan merged commit 5ef59a7 into GitTools:master Oct 2, 2016
@JakeGinnivan
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants