Skip to content

GH1055: Removed commas from tags section #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2016

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Oct 3, 2016

Relates to #1055

@gep13
Copy link
Member Author

gep13 commented Oct 3, 2016

@asbjornu this is why the Chocolatey Package isn't up to date.

Can you take a look at the changes when you have a minute? Thanks!

@gep13
Copy link
Member Author

gep13 commented Oct 3, 2016

@asbjornu @JakeGinnivan @pascalberger fairly sure the build failure is a red herring here.

But let me know if there is something else that needs to happen.

@asbjornu
Copy link
Member

asbjornu commented Oct 3, 2016

@gep13: This looks very innocent and should be fine. I don't like merging failed PR's though. Would be nice to have the build fixed first.

@gep13
Copy link
Member Author

gep13 commented Oct 3, 2016

@asbjornu see the convo in Gitter. I suspect that the GitHub Rate Limit for GitReleaseNotes is kicking in. Bottom line... No PR's as the build script currently stands should work. It is just a fluke that they are.

@pascalberger
Copy link
Member

@gep13 I've merged #1058. Can you rebase this on current master so that the builds will pass

@gep13
Copy link
Member Author

gep13 commented Oct 3, 2016

@pascalberger rebased. Thanks!

@pascalberger pascalberger merged commit 2a982a6 into GitTools:master Oct 3, 2016
@pascalberger
Copy link
Member

Thanks!

@gep13 gep13 deleted the feature/GH-1055 branch October 3, 2016 21:03
@asbjornu
Copy link
Member

asbjornu commented Oct 3, 2016

@gep13: Ah, brilliant! Thanks for this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants