Skip to content

Support setting Verbosity of GitVersion #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Support setting Verbosity of GitVersion #1081

wants to merge 5 commits into from

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Nov 8, 2016

Hi,

I added support to set verbosity of GitVersion when launching command line

GitVersion.exe -Verbosity Error allows to have less info/debug messages in your logs

fixes #955

Thomas P.

@@ -54,6 +54,13 @@ if($additionalArguments)
$argsGitVersion = $argsGitVersion + " $additionalArguments"
}

if(!$additionalArguments -or !$additionalArguments.Contains("-debug"))
{
if([string]::IsNullOrEmpty($env:SYSTEM_DEBUG) -or $env:SYSTEM_DEBUG -ne "true"){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too generic for a variable name. We should name it GITVERSION_LOG_LEVEL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where you were going with this now after looking through the commits. I am going to remove for now. I think we should extend the VSTS task to expose the log level.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Debug is the default variable for verbose output in VSTS. It would make sense IMHO to reuse the same variable as other build tasks are doing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this for the moment. I figured it can be another PR which we can look at separately

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@JakeGinnivan
Copy link
Contributor

The build is fixed now. If you could change the variable above and rebase this branch that would be great. You should be able to just git pull --rebase to rebase instead of merge

@JakeGinnivan JakeGinnivan mentioned this pull request Nov 27, 2016
@JakeGinnivan
Copy link
Contributor

This is in now through #1107. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Verbose/Debug logging level
3 participants