Skip to content

Fixes #1053: exclude NCrunch ItemGroup when NCrunch not present #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2016

Conversation

AGBrown
Copy link
Contributor

@AGBrown AGBrown commented Nov 18, 2016

This adds a condition to the ItemGroup that is required for NCrunch so that it is excluded when NCrunch is not installed. This is similar to the conditions here and here which also affect a section depending on the presence of NCrunch

This replaces #1082 (which was a PR into the support/3.6.0 branch) at the request of @pascalberger

@AGBrown
Copy link
Contributor Author

AGBrown commented Nov 18, 2016

appveyor error:

File not found: C:/projects/gitversion/build/releasenotes.md
Cake.exe : An error occurred when executing task 'Upload-AppVeyor-Artifacts'.
At line:1 char:1
+ & "C:\projects\gitversion\tools\Cake\Cake.exe" "build.cake" -target=" ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (An error occurr...yor-Artifacts'.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Error: 
UploadArtifact failed (2).
Command executed with exception: UploadArtifact failed (2).

@pascalberger
Copy link
Member

@AGBrown Thanks!

We are aware of the build issue and need to fix build on master first, afterwards you can rebase the branch and we can merge. I'll let you know as soon as master is fixed.

@@ -81,7 +81,7 @@
</Target>

<!--Support for ncrunch-->
<ItemGroup>
<ItemGroup Condition=" $(NCrunch) != '' ">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like that goe removed at some point. Thanks for fixing

@JakeGinnivan JakeGinnivan merged commit 49b2f3a into GitTools:master Nov 26, 2016
@AGBrown AGBrown deleted the bugfix/ncrunch-item-group branch November 26, 2016 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants