Invalid release version after commit beetween merge release to develop #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
reviewed
Apr 21, 2017
| // Check version on release after making some new commits | ||
| fixture.Repository.MakeACommit(); | ||
| fixture.Repository.MakeACommit(); | ||
| fixture.AssertFullSemver(config, "2.0.0-beta.4"); |
There was a problem hiding this comment.
Which version is produced here before your fix?
There was a problem hiding this comment.
Here 2.0.0-beta.3, but problem starts in previous assert (2.0.0-beta.1 instead of 2.0.0-beta.2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We detected problem with version calculating when someone will push commit beetween other person commit to release and merge to develop. Here's screen describing problem:
Actions in repo which are required:
I reproduced that situation in unit test by using commit merge instead of branch merge.