Skip to content

VsoAgentBuildNumberTests refactored with accordance to the remark from @asbjornu #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 5, 2017
Merged

VsoAgentBuildNumberTests refactored with accordance to the remark from @asbjornu #1260

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4596d98
VsoAgentBuildNumberTests refactored with accordance to the remark fro…
dpurge Jul 12, 2017
2d3debd
Remove empty test setup method from VsoAgentBuildNumberTests
dpurge Jul 12, 2017
ea0338b
Merge branch 'master' into bugfix/1257
asbjornu Jul 13, 2017
df2bcf7
Merge branch 'master' into bugfix/1257
Jul 28, 2017
9491472
Merge branch 'master' into bugfix/1257
asbjornu Aug 16, 2017
bb7b195
Merge branch 'master' into bugfix/1257
JakeGinnivan Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 18 additions & 39 deletions src/GitVersionCore.Tests/BuildServers/VsoAgentBuildNumberTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,65 +3,44 @@
using GitVersionCore.Tests;
using NUnit.Framework;
using Shouldly;
using System.Collections.Generic;

[TestFixture]
public class VsoAgentBuildNumberTests
{
string key = "BUILD_BUILDNUMBER";
string logPrefix = "##vso[build.updatebuildnumber]";
List<Tuple<string, string, string>> examples;
VsoAgent versionBuilder = new VsoAgent();

[SetUp]
public void SetUpVsoAgentBuildNumberTest()
{
examples = new List<Tuple<string, string, string>>();
}

[TearDown]
public void TearDownVsoAgentBuildNumberTest()
{
examples = null;
Environment.SetEnvironmentVariable(key, null, EnvironmentVariableTarget.Process);
}


[Test]
public void VsoAgentBuildNumberWithFullSemVer()
[TestCase("$(GitVersion.FullSemVer)", "1.0.0", "1.0.0")]
[TestCase("$(GITVERSION_FULLSEMVER)", "1.0.0", "1.0.0")]
[TestCase("$(GitVersion.FullSemVer)-Build.1234", "1.0.0", "1.0.0-Build.1234")]
[TestCase("$(GITVERSION_FULLSEMVER)-Build.1234", "1.0.0", "1.0.0-Build.1234")]
public void VsoAgentBuildNumberWithFullSemVer(string buildNumberFormat, string myFullSemVer, string expectedBuildNumber)
{
examples.Add(new Tuple<string, string, string>("$(GitVersion.FullSemVer)", "1.0.0", "1.0.0"));
examples.Add(new Tuple<string, string, string>("$(GITVERSION_FULLSEMVER)", "1.0.0", "1.0.0"));
examples.Add(new Tuple<string, string, string>("$(GitVersion.FullSemVer)-Build.1234", "1.0.0", "1.0.0-Build.1234"));
examples.Add(new Tuple<string, string, string>("$(GITVERSION_FULLSEMVER)-Build.1234", "1.0.0", "1.0.0-Build.1234"));

foreach (var example in examples)
{
Environment.SetEnvironmentVariable(key, example.Item1, EnvironmentVariableTarget.Process);
var vars = new TestableVersionVariables(fullSemVer: example.Item2);

var logMessage = versionBuilder.GenerateSetVersionMessage(vars);
logMessage.ShouldBe(logPrefix + example.Item3);
}
Environment.SetEnvironmentVariable(key, buildNumberFormat, EnvironmentVariableTarget.Process);
var vars = new TestableVersionVariables(fullSemVer: myFullSemVer);
var logMessage = versionBuilder.GenerateSetVersionMessage(vars);
logMessage.ShouldBe(logPrefix + expectedBuildNumber);
}


[Test]
public void VsoAgentBuildNumberWithSemVer()
[TestCase("$(GitVersion.SemVer)", "1.0.0", "1.0.0")]
[TestCase("$(GITVERSION_SEMVER)", "1.0.0", "1.0.0")]
[TestCase("$(GitVersion.SemVer)-Build.1234", "1.0.0", "1.0.0-Build.1234")]
[TestCase("$(GITVERSION_SEMVER)-Build.1234", "1.0.0", "1.0.0-Build.1234")]
public void VsoAgentBuildNumberWithSemVer(string buildNumberFormat, string mySemVer, string expectedBuildNumber)
{
examples.Add(new Tuple<string, string, string>("$(GitVersion.SemVer)", "1.0.0", "1.0.0"));
examples.Add(new Tuple<string, string, string>("$(GITVERSION_SEMVER)", "1.0.0", "1.0.0"));
examples.Add(new Tuple<string, string, string>("$(GitVersion.SemVer)-Build.1234", "1.0.0", "1.0.0-Build.1234"));
examples.Add(new Tuple<string, string, string>("$(GITVERSION_SEMVER)-Build.1234", "1.0.0", "1.0.0-Build.1234"));

foreach (var example in examples)
{
Environment.SetEnvironmentVariable(key, example.Item1, EnvironmentVariableTarget.Process);
var vars = new TestableVersionVariables(semVer: example.Item2);

var logMessage = versionBuilder.GenerateSetVersionMessage(vars);
logMessage.ShouldBe(logPrefix + example.Item3);
}
Environment.SetEnvironmentVariable(key, buildNumberFormat, EnvironmentVariableTarget.Process);
var vars = new TestableVersionVariables(semVer: mySemVer);
var logMessage = versionBuilder.GenerateSetVersionMessage(vars);
logMessage.ShouldBe(logPrefix + expectedBuildNumber);
}

}