Ensure that PreReleaseNumber is always a number

[pitermarx]

Because of the JsonOutputFormatter, the json output can either be "PreReleaseNumber": number or "PreReleaseNumber": null
this can have impact on desserialization as found on Cake

[matkoch]

@pitermarx I don't think this should be done. There is a meaningful difference between a PreReleaseNumber being null or 0.

[asbjornu]

@pitermarx: I agree with @matkoch. I interpret a PreReleaseNumber set to 0 to mean that the release is not stable and at version 0. A PreReleaseNumber set to null indicates that the release is stable. To represent this property in C#, I would use Nullable<int>, so both states can be captured.

[pitermarx]

I agree. Pls reject this PR. I just wanted to raise attention to this

…

-- Pedro Marques No dia 15/09/2017, às 12:59, Asbjørn Ulsberg <[email protected]> escreveu:

@pitermarx: I agree with @matkoch. I interpret a PreReleaseNumber set to 0 to mean that the release is not stable and at version 0. A PreReleaseNumber set to null indicates that the release is stable. To represent this property in C#, I would use Nullable<int>, so both states can be captured. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.