Skip to content

Add VS extension updater #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

twsouthwick
Copy link
Contributor

This adds a task to update VSIX manifest files if they are present in the project. This is done by hooking itself such that it runs right before CreateVsixPackage if it exists. The update is done on the intermediate manifest, so the original copy is not changed and thus the version update is transparent to the user.

@JakeGinnivan
Copy link
Contributor

I am in two minds about this, @gep13 @asbjornu feel free to disagree, but I think we should have less of these specific updates.

GitVersion should focus on generating the version number, in the Task it should be a msbuild variable which can be used by tasks like this, but they probably shouldn't live inside this repo.

This is an extension to the discussion if should we update .net core versions etc. Thoughts? Should be maybe create another repo with a heap of tasks and helpers to update various types of projects?

@asbjornu
Copy link
Member

asbjornu commented Dec 9, 2017

I agree that the different outputs should be separated from the core and from each other.

@gep13
Copy link
Member

gep13 commented Dec 9, 2017

@JakeGinnivan yes, I totally agree with you. GitVersion should be the tool to assert the version number. There are plenty of other tools, like MagicChunks, that can then be used to take that version number and update the required files.

@twsouthwick
Copy link
Contributor Author

That sounds fine. I wanted to look at contributing this here first for easier discoverability if there was interest, but will package it elsewhere. Thanks for the work with GitVersion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants