Fix addin/tool versions #1340
Fix addin/tool versions #1340
Conversation
gep13
commented
Dec 6, 2017
gep13
commented
- This will make the builds more reliable and repeatable
- This will make the builds more reliable and repeatable
|
@JakeGinnivan can you take a look at this? |
There was a problem hiding this comment.
LGTM 👍
Unfortunately I don't have permissions to merge it as long as a build fails. The failing AppVeyor build doesn't seem to be related to this change (it creates gitversion-4.0.0.fix.pre.addin.pre.tool.pre.versions.1.gem and tries to upload gitversion-4.0.0.fix-addin-tool-versions.1.gem)
|
@pascalberger yeah, that sounds like another bug that needs to be resolved. I can try to take a look at that later, but can't guarantee it :-( |
|
Looks good to me, but we can't release beta13/14 yet. I have been testing and had scenarios where it isn't picking up merge messages, I think we have a decent regression somewhere |
|
@JakeGinnivan ouch! Is this showing up in the tests, or just from your own testing? |
|
Just from my own testing. Also, there is a branch config inheritance issue.. See https://travis-ci.org/GitTools/GitVersion/jobs/312274320 - got stuck in a loop.. May take me a day or two, but I will try to add the tests and ensure we don't have those regressions. It would be handy if everyone could build and do some basic testing of master on their own code bases to see if there are issues |
|
Hopefully this should go green now, then can merge and we should be good to release beta.14 |
|
@JakeGinnivan looks like there is still an issue with the uploading of artifacts. |
|
Odd that it's the branch build failing but all others succeed. I recon we just merge. It's probably a gem precondition not creating it for that build |
