Initial refactoring of Variable provider and the way variables are gener... #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerated. Also using SemVer 2.0
| Stability = releaseInformation.Stability; | ||
| var thisType = typeof(GetVersion); | ||
| var variables = versionAndBranch.ToKeyValue(); | ||
| foreach (var variable in variables) |
There was a problem hiding this comment.
There is a test enforcing the msbuild task outputs match the variable provider
added 7 commits
March 29, 2014 17:18
|
Sorry for the size, went on a bit of a cleaning spree. I think the end result is a bit simpler, also I recon the version finder classes will be able to be simplified as a next step I need to write some more tests around all the new formatting stuff in the SemVer classes, and I would also like to replace a bunch of the tests with higher scenario level tests @SimonCropp if you do the split today, can you base it on this branch if you are happy with the PR in general (and leave comments for anything specific to fix) |
|
I also think #122 should be really easy to fix from this point |
added 10 commits
March 30, 2014 09:37
andreasohlund
added a commit
that referenced
this pull request
Mar 30, 2014
Initial refactoring of Variable provider and the way variables are gener...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ated. Also using SemVer 2.0
Fixes #113 currently
I plan on doing more to this