Make sure GetVersion is called for project references #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged? We need to this be able to use the new NuGet feature coming soon in the VS 2017 15.6 update. |
|
FYI Visual Studio 2017 15.6 is out now, so we really need to get this merged in. Is anyone around anymore? |
|
Thank you @bording! I tried it out in my project and it works great. 😄 |
This was referenced Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this property ensures that the GetVersion target will be called in the right place when NuGet's Pack target is calculating the version for project references.
This is using the new feature in NuGet/NuGet.Client#1915 to do this, so you won't see it actually doing anything until an updated version of NuGet is released.