Skip to content

Fix dotnet publish and VS2017 #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix dotnet publish and VS2017 #1368

wants to merge 4 commits into from

Conversation

maikebing
Copy link

ILRepack is removed.
dotnet publish can publish you dotnet core projects !

@maikebing
Copy link
Author

@asbjornu @gep13 @pascalberger can you review it and merge or talk about this pr ?

@asbjornu
Copy link
Member

asbjornu commented Feb 5, 2018

Are we dogfooding or testing the changes that are made here in any way?

@maikebing
Copy link
Author

I compile and use it in a production environment and it seems to be fine at the moment.

@asbjornu
Copy link
Member

asbjornu commented Mar 9, 2018

@maikebing: What I meant was: Is GitVersion using the result in the build so if you actually broke something in this PR, we would notice it?

@asbjornu asbjornu requested a review from dazinator March 28, 2018 08:36
@asbjornu
Copy link
Member

@dazinator: Can you please take a look at this and whether it's something we want to merge? Aren't you dealing with many of the same issues in #1269?

@maikebing
Copy link
Author

@asbjornu
Here's what to note:
1, ILRepack can not be a good combination of. Net Core dependencies, so abolished it.
2, except VS2017 I did not test in other versions of VS.

@maikebing
Copy link
Author

If there is any question and need me to do, please tell me, I hope to do better.
@asbjornu

@dazinator
Copy link
Member

Yeah this is covered in the netstandard pr, along with the other dotnet cli commands (restore, build, pack, etc). If its possible hold off merging this one then it will result in an easier merge of that other PR (less conflicts to resolve) whenever that happens.

@dazinator
Copy link
Member

Closing this as the latest netstandard PR should have addressed this, please comment if not.

@dazinator dazinator closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants