Add C++ (Modern/UWP,MFC, etc.) support for SemVer in GitVersion #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two simple steps to get this working 1) Create a file called "GitVersionTaskAssemblyInfo.h" right beside your .vcxproj 2) Fill it with this: #pragma once #define VERSION_STR(x) #x #define VERSION_XSTR(x) VERSION_STR(x) #define VERSION_BLANK "" #define VERSION_FULL 0,0,0,0 #define VERSION_STRING VERSION_XSTR(0.0.0.0) VERSION_BLANK "\0" 3) Create a version resource (filename does not matter) 4) Modify the code: ++ Add "#include "GitVersionAssemblyInfo.g.h" somewhere near the top Modify the versioninfo lines to be (lines 53,54 in a typical, default Version resouce file): FILEVERSION VERSION_FULL PRODUCTVERSION VERSION_FULL and Modify the block for the PE description as follows for the FileVersion and ProductVersion lines VALUE "FileVersion", VERSION_FULL VALUE "ProductVersion", VERSION_STRING
Shouldn't leave this in there for pull request.
| @@ -47,7 +47,9 @@ | |||
| <HintPath>..\packages\LibGit2Sharp.0.23.0-pre20160922233542\lib\net40\LibGit2Sharp.dll</HintPath> | |||
| <Private>True</Private> | |||
| </Reference> | |||
| <Reference Include="System" /> | |||
| <Reference Include="System"> | |||
| <HintPath>..\..\..\..\..\..\..\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.dll</HintPath> | |||
There was a problem hiding this comment.
I think you don't need to reference assembly by explicit path.
There was a problem hiding this comment.
Bah! I blame visual studio for this abomination! Thanks. I will just revert this to the original line.
Going back to the original value of this Reference node.
Not sure why this is failing in appveyor. Adding standard whitespace before Node termination.
|
Bah! Time to re-base and resubmit... Apologies guys! |
|
@denis-ivanov I have submitted a new PR. Can you please review? I did not realize that your VS projects were on steroids and I didn't actually need to modify them. I'm not used to that from VS projects. This pleases me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few simple steps to get this working
#pragma once
#define VERSION_STR(x) #x
#define VERSION_XSTR(x) VERSION_STR(x)
#define VERSION_BLANK ""
#define VERSION_FULL 0,0,0,0
#define VERSION_STRING VERSION_XSTR(0.0.0.0) VERSION_BLANK "\0"
++ Add "#include "GitVersionAssemblyInfo.g.h" somewhere near the top
Modify the versioninfo lines to be (lines 53,54 in a typical, default Version resouce file):
FILEVERSION VERSION_FULL
PRODUCTVERSION VERSION_FULL
and
Modify the block for the PE description as follows for the FileVersion and ProductVersion lines
VALUE "FileVersion", VERSION_FULL
VALUE "ProductVersion", VERSION_STRING
Add your GitVersion.yml to your heart's delight.
Drink coffee (or beverage of choice).