Parallelize unit tests #1584
Merged
Parallelize unit tests #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
force-pushed
the
feature/parallelize-unit-tests
branch
6 times, most recently
from
f031ded to
63cb9f1
Compare
# Conflicts: # src/GitVersionCore.Tests/AssemblyInfoFileUpdaterTests.cs # src/GitVersionCore.Tests/GitVersionCore.Tests.csproj # src/GitVersionCore.Tests/GitVersionInformationGeneratorTests.cs # src/GitVersionExe.Tests/GitVersionExe.Tests.csproj # src/GitVersionTask.Tests/GitVersionTask.Tests.csproj
Add length check for log indent level to avoid exceptions like this: Error Message: System.ArgumentOutOfRangeException : Length cannot be less than zero. Parameter name: length Stack Trace: at System.String.Substring (System.Int32 startIndex, System.Int32 length) [0x0004a] in <f3f2aa82c3a04d48845485ce37124803>:0 at GitVersion.Logger+<>c__DisplayClass19_0.<IndentLog>b__0 () [0x00010] in <05fc21618d444a47be7b45d99fa1d3c6>:0 at GitVersion.Logger+ActionDisposable.Dispose () [0x00000] in <05fc21618d444a47be7b45d99fa1d3c6>:0 at GitVersion.VersionCalculation.BaseVersionCalculator.GetBaseVersion (GitVersion.GitVersionContext context) [0x00211] in <05fc21618d444a47be7b45d99fa1d3c6>:0 at GitVersion.VersionCalculation.NextVersionCalculator.FindVersion (GitVersion.GitVersionContext context) [0x0003f] in <05fc21618d444a47be7b45d99fa1d3c6>:0 at GitVersion.GitVersionFinder.FindVersion (GitVersion.GitVersionContext context) [0x000a1] in <05fc21618d444a47be7b45d99fa1d3c6>:0 at GitVersionCore.Tests.GitToolsTestingExtensions.ExecuteGitVersion (GitVersion.GitVersionContext context) [0x00007] in <e141d799e05748d0bf9753d21cdcadd7>:0 at GitVersionCore.Tests.GitToolsTestingExtensions.GetVersion (GitTools.Testing.RepositoryFixtureBase fixture, GitVersion.Config configuration, LibGit2Sharp.IRepository repository, System.String commitId, System.Boolean isForTrackedBranchOnly, System.String targetBranch) [0x00030] in <e141d799e05748d0bf9753d21cdcadd7>:0 at GitVersionCore.Tests.GitToolsTestingExtensions.AssertFullSemver (GitTools.Testing.RepositoryFixtureBase fixture, GitVersion.Config configuration, System.String fullSemver, LibGit2Sharp.IRepository repository, System.String commitId, System.Boolean isForTrackedBranchOnly, System.String targetBranch) [0x00050] in <e141d799e05748d0bf9753d21cdcadd7>:0 at GitVersionCore.Tests.GitToolsTestingExtensions.AssertFullSemver (GitTools.Testing.RepositoryFixtureBase fixture, System.String fullSemver, LibGit2Sharp.IRepository repository, System.String commitId, System.Boolean isForTrackedBranchOnly, System.String targetBranch) [0x00007] in <e141d799e05748d0bf9753d21cdcadd7>:0 at DocumentationSamples.GitFlowFeatureBranch () [0x000a2] in <e141d799e05748d0bf9753d21cdcadd7>:0 at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&) at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in <f3f2aa82c3a04d48845485ce37124803>:0 https://dev.azure.com/GitTools/GitVersion/_build/results?buildId=191&view=logs&jobId=a5e52b91-c83f-5429-4a68-c246fc63a4f7&taskId=d6b35a2b-3a7d-590e-76eb-a415813199f6&lineStart=225&lineEnd=226&colStart=1&colEnd=1
Add try/catch around teardown code to avoid errors like this: An error occurred in a custom teardown action. Teardown error: System.InvalidOperationException: The context data has not been setup. at Cake.Core.CakeDataService.Get[TData]() in C:\projects\cake\src\Cake.Core\CakeDataService.cs:line 32 at Cake.Core.CakeEngineActions.<>c__DisplayClass21_0`1.<RegisterTeardown>b__0(ITeardownContext context) in C:\projects\cake\src\Cake.Core\CakeEngineActions.cs:line 64 at Cake.Core.CakeEngine.PerformTeardown(IExecutionStrategy strategy, ICakeContext context, Stopwatch stopWatch, CakeReport report, Boolean exceptionWasThrown, Exception thrownException) in C:\projects\cake\src\Cake.Core\CakeEngine.cs:line 493 https://travis-ci.org/GitTools/GitVersion/jobs/495911487#L1914
|
@asbjornu can you squash the commits as one commit? |
|
@arturcic: I'm personally not a fan of squashing commits, since we loose the thought process and meaning behind many of the code changes. I find the commit messages in 9d00191, 4c4c08d and 63cb9f1 valuable in the case similar problems surface in the future. If we squash, those messages go away or get attached to a single large commit that also deals with other stuff, so the intent becomes unclear. I'm all for rebasing a PR to get rid of merge-commits (updates) from |
|
Agree with the point, but in this particular case it's about testing the CI if the build fails, that's why I thought better to have one commit that represents the actual change to the code base that improves it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1384 to see if the failing tests can be fixed somehow. Resolves #1384.