[Configuration Bugfix] source-branches is overwritten even if explicitly specified in the config #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Adding source-branches to the config had no effect and would always be over-written with the default value specified in the configuration provider for the default branches. Cause: SourceBranches from BranchConfig was not being checked before being over-written. Fix: Check SourceBranches and use it before applying the defaults.
…_should_not_be_overwritten
…_should_not_be_overwritten
…_should_not_be_overwritten
ruhullahshah
deleted the
bugfix/source_branches_specified_in_config_should_not_be_overwritten
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Adding source-branches to the config has no effect and is always overwritten with the default values.
Steps to Reproduce:
Add
source-branches: ['develop']to thedevelopbranch configuration and upon runningGitVersion.exe /showconfigthesource-branches: []will be displayed.Cause:
SourceBranchesfromBranchConfigwas not being checked before applying the defaults.Fix:
Check
SourceBranchesbefore applying the defaults.The reason for creating the fix from the tip of 4.0.0 is that, we expect it to get merged into a support/4.0.x branch, providing an alternative for the users who do not want to upgrade to 5.0.0 yet.