Skip to content

fix Cannot find module 'argparse' issue #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

flomader
Copy link

@flomader flomader commented Mar 8, 2019

Resolves #1610

@arturcic
Copy link
Member

arturcic commented Mar 8, 2019

LGTM!!

Unfortunately we cannot publish the pre-release versions as of now via CI, as we don't have valid token for publishing.
@JakeGinnivan we need valid token for marketplace publishing.

I'll merge the PR, thank you for your contribution!

@arturcic arturcic merged commit 5c1db80 into GitTools:master Mar 8, 2019
@asbjornu
Copy link
Member

@arturcic, I know @JakeGinnivan has too many GitHub notifications to follow them, so please try to reach out to him in other channels.

@jaq316
Copy link

jaq316 commented Apr 8, 2019

Any luck on reaching @JakeGinnivan ?

@gep13
Copy link
Member

gep13 commented Apr 8, 2019

@arturcic @asbjornu what exactly is required here?

@arturcic
Copy link
Member

arturcic commented Apr 8, 2019

@gep13 we need a valid PAT (personal access token) on marketplace. I am a member on marketplace, but the PAT I generate is not valid, last time @JakeGinnivan has generated one. I talked to Jake few weeks ago when this issue first time appeared. I did not have time to ping him again.

@arturcic
Copy link
Member

arturcic commented Apr 8, 2019

Would be great if I can generate myself a valid PAT

@asbjornu
Copy link
Member

asbjornu commented Apr 8, 2019

What would be required for you to generate a valid PAT, @arturcic?

@arturcic
Copy link
Member

arturcic commented Apr 8, 2019

That's only an assumption, to have a valid PAT you need to have owner permissions, currently I have only contributor, Jake and Pascal have owner. Still I am able to manually publish the artifacts on marketsplace, but not from command line in a CI scenario

@gep13
Copy link
Member

gep13 commented Apr 8, 2019

@arturcic ok, this is something we need to get sorted out. Are there any other permissions that are needed?

@gep13
Copy link
Member

gep13 commented Apr 9, 2019

@asbjornu I reached out to @JakeGinnivan and he has issued @arturcic with a PAT that will get him started. He mentioned that you are an Administrator of the VSTS Project. Are you in a position to add @arturcic as an administrator as well (as well as everyone else on the team)?

@arturcic
Copy link
Member

I got the new PAT from @JakeGinnivan, but it seems it's not valid :(

@gep13
Copy link
Member

gep13 commented Apr 10, 2019

@arturcic doh! :-( @asbjornu would you be able to have a look at this, to see if you can create a PAT, or ideally, add @arturcic to the package as well?

@kicybot
Copy link

kicybot commented Apr 10, 2019

Looking forward to this release in Azure DevOps :)

@asbjornu
Copy link
Member

In the settings for GitVersion on Azure DevOps, @arturcic is listed as an administrator already.

@arturcic
Copy link
Member

That is right, but I need to be here https://marketplace.visualstudio.com/manage/publishers/gittools

@arturcic
Copy link
Member

image

@gep13
Copy link
Member

gep13 commented Apr 10, 2019

Perhaps @pascalberger can help in this regard as well?

@asbjornu
Copy link
Member

Aha. I have no access there at all:

Screenshot 2019-04-10 at 10 56 12

Can @pascalberger please make @arturcic an owner then?

@gep13
Copy link
Member

gep13 commented Apr 10, 2019

Sounds like it would be good to get yourself @asbjornu added in there as well 😄 Is there anyone else that should be added? Is there a document that lists all the places that contributors to GitVersion need to be given access? I think that this would be a good thing to have, as a reference for bringing on new people. Perhaps this is something that @arturcic could compile, since he has gone through it most recently?

@arturcic
Copy link
Member

Sure

@asbjornu
Copy link
Member

Yep, I wouldn't mind having access, @gep13. Just need to get @pascalberger's attention. 😄

@pascalberger
Copy link
Member

Where do I need to give you permissions? In the Azure DevOps organization you seem to be already an collection administrator @asbjornu. I failed to find where to set permissions for marketplace when I looked quickly. Do you know how to get there?

I'll be occupied with meetings the whole day, but try to have another look as soon as I find a few minutes.

@asbjornu
Copy link
Member

@pascalberger, it's in here as @arturcic wrote in #1631 (comment).

@pascalberger
Copy link
Member

@asbjornu Mmh, I also get a 403 while accessing this site...

@gep13
Copy link
Member

gep13 commented Apr 10, 2019

@pascalberger @asbjornu @arturcic I have reached out to @JakeGinnivan to see if he can offer any help here.

@JakeGinnivan
Copy link
Contributor

Finally got the right permissions page thanks to the link @asbjornu posted the other day. I was in a totally different area trying to grant permissions..

@arturcic you are owner, I can't add @gep13 or @asbjornu because apparently .co.uk and .no are both not valid domains :P

@gep13
Copy link
Member

gep13 commented Apr 14, 2019

@asbjornu my suspicion is that it is complaining because mine is an MSA with custom domain. I have passed on another email address to @JakeGinnivan

@asbjornu
Copy link
Member

My Gmail address might be considered valid, perhaps. I’ll DM it to you, @JakeGinnivan.

@mvrmoreira
Copy link

Nice!

@ahmadakhmiev
Copy link

Any progress on this one guys?

@arturcic
Copy link
Member

I'll try to generate a new token and try to upload a vsix from command line to see if it works, I hope I can find some time today

@jaq316
Copy link

jaq316 commented Apr 18, 2019

Any progress here?

@arturcic
Copy link
Member

Unfortunately none, busy with other stuff for now, hopefully will have time to have a look. Sorry, doing only when I have some free time left, it's not my day by day job

@jaq316
Copy link

jaq316 commented Apr 18, 2019

Ofcourse. Thank you. Wish I could contribute in solving this.

@jaq316
Copy link

jaq316 commented Apr 25, 2019

Is there anything I can do to help this along?

@xzuttz
Copy link

xzuttz commented May 1, 2019

This is ridiculous

@gep13
Copy link
Member

gep13 commented May 1, 2019

@xzuttz said...
This is ridiculous

This is open source. There are no guarantees when, or if, things well get done. All time given to this repository and its tools is volunteer, and I would ask you to consider that when posting things like this.

@cyan198
Copy link

cyan198 commented Jun 20, 2019

I tried today and I'm also having this issue in linux agent. I guess it hasn't released to marketplace?

Thanks.

@kmiterror
Copy link

Since it takes long to update the Azure DevOps task I have made a workaround.
Install .net core git version cli
Add ".NET Core" task to your build
Set Command to "Custom"
Set Custom Command to "tool"
Set Arguments to "install -g GitVersion.Tool --version 5.0.0 --ignore-failed-sources"

Use gitversion tool
Add ".NET Core" task to your build
Set Command to "Custom"
Set Custom Command to "gitversion"
Set Arguments to "/output buildserver /nofetch"

In fact -g option in first step should not be used because it install gitversion globally.
It might be a good enough workaround for most Azure DevOps users.

@arturcic
Copy link
Member

@kmiterror I wonder why don't you use the latest task? https://marketplace.visualstudio.com/items?itemName=gittools.gitversion. You will have to unistall and then install back to the organization. Otherwise it's using the older cached version

@arturcic
Copy link
Member

@cyan198 , it was already released

@kmiterror
Copy link

Ahh, I missed that one, I assumed that since the issue is not closed then it's not released yet.
If that's the case my workaround is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitVersion .Net Core (Preview) Azure DevOps task error