Skip to content

Initial support of Drone #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2019
Merged

Initial support of Drone #1654

merged 3 commits into from
May 20, 2019

Conversation

vhatsura
Copy link
Contributor

@vhatsura vhatsura commented Apr 4, 2019

The pull request add initial support of Drone. to fix #1658

@vhatsura
Copy link
Contributor Author

vhatsura commented Apr 14, 2019

Hey, @arturcic!
Could you look into PR, please? It's important for us due to we cannot use git version with Drone in case of build source code from pull request (git version can resolve current branch to calculate version).

@vhatsura
Copy link
Contributor Author

@JakeGinnivan , @SimonCropp , can you look into this PR, please?

@SimonCropp
Copy link
Contributor

@vhatsura sorry, i am no longer contributing to this project

@arturcic
Copy link
Member

I guess adding Drone is a good addition, as it allows building on ARM chip. I guess we could also add support for building GitVersion on ARM as Libgit2Sharp is already adding supporting for ARM.

@arturcic arturcic merged commit 4448cb5 into GitTools:master May 20, 2019
@arturcic
Copy link
Member

@vhatsura thank you for you contribution! Do you mind checking how it works on Drone CI with the latest changes and give us feedback? And sorry it took so long.

@arturcic arturcic added this to the 5.0.0 milestone May 20, 2019
@vhatsura vhatsura deleted the drone branch May 20, 2019 11:09
@vhatsura
Copy link
Contributor Author

@arturcic, sure. will check it. To be honest, GitVersion worked on Drone CI, however, during building PRs was some issues with branch identification.

@arturcic
Copy link
Member

Now that the changes are merged hope it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Drone
3 participants