Allow overriding of the config file path

[chuseman]

This adds a new abstract ConfigFileLocator class, which has two implementations:

• DefaultConfigFileLocator, which is the current logic (GitVersion.yml and GitVersionConfig.yaml in working and project root directories).
• NamedConfigFileLocator that will only look for a specific file path (it can be a relative or absolute path).

GitVersionExe has a new optional /config argument which takes a path.

GitVersionTask has a new ConfigFilePath property on all inputs and is exposed via the MSBuild GitVersionConfig property.

GitVersionTfsTask has a new configFilePath input.

This resolves #894.

[asbjornu]

I think this looks excellent. Can you please rebase the changes on top of HEAD of master and force-push the changes so we get a fresh PR? I'll merge as soon as it lights up green.

[chuseman]

Looks like I'm running into some flaky tests here?

Should I drop my last commit? I think Shouldly will give you better error messages for failures if you use it this way, but it isn't related to my PR.

[arturcic]

@chuseman could you please rebase on top of master as there are some changes to the vsix version.

[asbjornu]

Thanks for your contributions, @chuseman!

[Skoucail]

I believe this feature introduced a unwanted breaking change in the GitVersionTfsTask.
If i leave the Config file field empty i believe it should look for GitVersion.yml files in the working directory and the project directory.
But as the task always calls gitversion with /config it doesn't look for any GitVersion.yml files. And doesn't even use the GitVersion.yml in the working directory.

I believe the problem is that configFilePath is of type filePath. So if you enter something relative (or empty) Azure DevOps will always pretent the working directory. So in the GitVersion.ts the property configFilePath will always contain a value (working directory) and will result in always adding the /config param.

Resulting in command below (Config file field set empty)
[command]"C:\Program Files\dotnet\dotnet.exe" D:\azagent1_work_tasks\GitVersion_e5983830-3f75-11e5-82ed-81492570a08e\5.0.1\core\GitVersion.dll D:\azagent1_work\7\s /output buildserver /nofetch /config D:\azagent1_work\7\s /updateassemblyinfo true

[asbjornu]

@Skoucail, this should be fixed in #1777. Can you please verify?

[Skoucail]

@asbjornu I can test it on Monday. Is the fix available in the gitversion (preview) version (5.0.2) of the azure devops task?

[arturcic]

@Skoucail you can use the preview version of the task - https://marketplace.visualstudio.com/items?itemName=gittools.gitversion-preview

[arturcic]

If the code is merged it should be available in the preview version

[chuseman]

FWIW, I've verified the fix on our Azure DevOps Server 2019 instance with the preview version. The /config parameter is no longer passed unless the task specifies it.

[Skoucail]

FWIW, I've verified the fix on our Azure DevOps Server 2019 instance with the preview version. The /config parameter is no longer passed unless the task specifies it.

Same here, looks fine now. Thx for fixing @chuseman