Skip to content

#1754 Allow head to move when switching branches for dynamic repositories #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

#1754 Allow head to move when switching branches for dynamic repositories #1758

merged 1 commit into from
Jul 30, 2019

Conversation

GeertvanHorrik
Copy link
Contributor

Fixes #1754

@GeertvanHorrik GeertvanHorrik requested a review from arturcic July 28, 2019 13:05
tests-checker[bot]
tests-checker bot suggested changes Jul 28, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

arturcic
arturcic approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arturcic arturcic requested a review from asbjornu July 29, 2019 06:25
@arturcic arturcic added this to the 5.0.0 milestone Jul 29, 2019
@arturcic arturcic added the bug label Jul 29, 2019
@arturcic arturcic merged commit 6a0558b into master Jul 30, 2019
@arturcic
Copy link
Member

@GeertvanHorrik, your changes have been merged, thanks for your contribution 👍

@arturcic arturcic deleted the pr/DynamicRepositories branch July 30, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@arturcic arturcic arturcic approved these changes

@asbjornu asbjornu Awaiting requested review from asbjornu

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

"GitVersion has a bug, your HEAD has moved after repo normalisation." reported
2 participants
@GeertvanHorrik @arturcic