Skip to content

Feature/unit tests vsix #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2019
Merged

Conversation

arturcic
Copy link
Member

Added initial unit testing for vsix, written in nodejs with mocha.

@arturcic arturcic requested a review from asbjornu August 28, 2019 15:05
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these tests are actually executed (I can't figure out where atm.), this looks great! Thanks for your persistence on making GitVersion better, @arturcic! 🙏 ❤️

@arturcic
Copy link
Member Author

The tests are actually executed, they do execute the GitVersion.js wrapper, but for now checking all the inputs are set correct and the generated command is the expected. Not testing GitVersion.dll/exe as we do it in the .net unit tests

@arturcic arturcic force-pushed the feature/UnitTestsVsix branch from b102f82 to a41056e Compare August 29, 2019 11:02
@arturcic arturcic force-pushed the feature/UnitTestsVsix branch from f5454b1 to c55a005 Compare August 29, 2019 11:12
@arturcic
Copy link
Member Author

@asbjornu changes applied

@arturcic arturcic force-pushed the feature/UnitTestsVsix branch from a281202 to 91f7b3d Compare August 29, 2019 12:27
@arturcic arturcic force-pushed the feature/UnitTestsVsix branch from 1fe00ef to 783cd61 Compare August 29, 2019 13:17
@arturcic arturcic merged commit b8f8c4e into GitTools:master Aug 29, 2019
@arturcic arturcic added this to the 5.1.0 milestone Aug 29, 2019
@arturcic arturcic deleted the feature/UnitTestsVsix branch August 29, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants