-
Notifications
You must be signed in to change notification settings - Fork 654
Feature/unit tests vsix #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/unit tests vsix #1794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming these tests are actually executed (I can't figure out where atm.), this looks great! Thanks for your persistence on making GitVersion better, @arturcic! 🙏 ❤️
The tests are actually executed, they do execute the GitVersion.js wrapper, but for now checking all the inputs are set correct and the generated command is the expected. Not testing GitVersion.dll/exe as we do it in the .net unit tests |
b102f82
to
a41056e
Compare
f5454b1
to
c55a005
Compare
@asbjornu changes applied |
a281202
to
91f7b3d
Compare
1fe00ef
to
783cd61
Compare
Added initial unit testing for vsix, written in nodejs with mocha.