Skip to content

adds Preview suffix to VSIX task name when appropriate #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thoemmi
Copy link
Contributor

@thoemmi thoemmi commented Oct 28, 2019

Currently the GitVersion tasks from the release and the preview extension are named "GitVersion Task". If both extensions are installed, you cannot distinguish them by name.

This PR adds a " (Preview)" suffix to the task's displayname, just like it's already done for the extension itself.

@arturcic
Copy link
Member

Looks good to me! Thanks for the PR. I'll merge the changes when the build finishes

@arturcic arturcic added this to the 5.1.0 milestone Oct 28, 2019
@thoemmi
Copy link
Contributor Author

thoemmi commented Oct 28, 2019

I'am afraid the name of my branch is too long, the AppVeyor build failed with

Executing: "C:/ProgramData/chocolatey/bin/Choco.exe" pack -v -y --version "5.1.0-add-preview-suffix-1-203" "C:/projects/gitversion/nuspec/GitVersion.Portable.temp.nuspec"
Chocolatey v0.10.15
Attempting to build package from 'GitVersion.Portable.temp.nuspec'.
The special version part cannot exceed 20 characters.
An error occurred when executing task 'Pack-Chocolatey'

@arturcic
Copy link
Member

if Azure pipelines succeeds I'll merge. Appveyor is only for backup

@arturcic
Copy link
Member

next time just put a shorter, simpler branch name

@arturcic arturcic merged commit 16ae98e into GitTools:master Oct 28, 2019
@arturcic
Copy link
Member

Thank you so much for your contributions, @thoemmi 👍 . The the build finishes you should uninstall and install the extension, if you want to see the change

@thoemmi thoemmi deleted the features/add-preview-suffix-to-task-name branch October 28, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants