Skip to content

Documentation enhanced concerning issue #888 #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Documentation enhanced concerning issue #888 #2025

merged 3 commits into from
Jan 7, 2020

Conversation

teneko
Copy link
Contributor

@teneko teneko commented Jan 7, 2020

Documentation enhanced concerning issue #888 (#888)

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a few nitpicks.

@teneko
Copy link
Contributor Author

teneko commented Jan 7, 2020

Men, I've never edited a pull reqeust in GitHub. Completely new territorium. Sorry for the many new commits... I see you can batch changes. Very confusing when not worked with before.

@gep13
Copy link
Member

gep13 commented Jan 7, 2020

@teroneko said..
Men, I've never edited a pull reqeust in GitHub. Completely new territorium. Sorry for the many new commits... I see you can batch changes. Very confusing when not worked with before.

I took the liberty of rebasing your changes into the two main commits. Let me know if this causes you problems on your local working copy of the repository, and we can get that sorted for you.

@teneko teneko requested a review from asbjornu January 7, 2020 09:53
@asbjornu asbjornu merged commit f2183e2 into GitTools:master Jan 7, 2020
@asbjornu
Copy link
Member

asbjornu commented Jan 7, 2020

Thank you for your contributions, @teroneko!

arturcic pushed a commit that referenced this pull request Jan 7, 2020
Merge pull request #2025 from teroneko/issue-888

GH-888: Improved documentation for `continuous-delivery-fallback-tag`
@arturcic arturcic added this to the 5.1.4 milestone Jan 7, 2020
@teneko teneko deleted the issue-888 branch January 9, 2020 07:20
@teneko teneko restored the issue-888 branch June 22, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants