Fixes #1796 by using a constant file name #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a file inside `intermediateOutputPath` the file name must be constant. When creating a file inside `TempPath` the file name must or should be random.
|
This looks good, but since it was undetected by tests previously, would it be possible to add a test that provokes the old and bad behaviour and thus ensures we won't have any regressions in the future? |
|
Added tests for my fixes and also for |
|
Superb! Thanks so much for your contributions, @batzen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a file inside
intermediateOutputPaththe file name must be constant.When creating a file inside
TempPaththe file name must or should be random.I am not even sure if using a random file name every time when using
TempPathis a good idea as we would be polluting the temp path that way.Fixes #1796.