GH2139: GitVersion logging does not include newlines #2146

gitfool · 2020-02-29T01:04:07Z

I also tried to fix newlines to be platform agnostic.
Finally, I suppressed CS0618 and NU1701 build warnings.

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0618

https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1701

gitfool · 2020-02-29T21:09:54Z

Linux raw logs from GitHub Actions captured before this change:

2020-02-29T20:29:03.9061303Z Executing: dotnet tool install "GitVersion.Tool" --tool-path "/home/runner/work/build-cake/build-cake/tools" --version 5.1.3 --verbosity diagnostic
...
2020-02-29T20:29:11.9027214Z Executing: /home/runner/work/build-cake/build-cake/tools/dotnet-gitversion -output json -verbosity Debug
2020-02-29T20:29:12.2343309Z INFO [02/29/20 20:29:12:09] Applicable build agent found: 'GitHubActions'.INFO [02/29/20 20:29:12:09] Working directory: /home/runner/work/build-cake/build-cakeINFO [02/29/20 20:29:12:09] IsDynamicGitRepository: FalseINFO [02/29/20 20:29:12:10] Returning Project Root from DotGitDirectory: /home/runner/work/build-cake/build-cake/.git/ - /home/runner/work/build-cake/build-cake/INFO [02/29/20 20:29:12:11] Running on Unix.INFO [02/29/20 20:29:12:11] Applicable build agent found: 'GitHubActions'.INFO [02/29/20 20:29:12:11] Branch from build environment: INFO [02/29/20 20:29:12:11] Begin: Normalizing git directory for branch ''  INFO [02/29/20 20:29:12:13] One remote found (origin -> 'https://github.com/pharos/build-cake').  INFO [02/29/20 20:29:12:13] Skipping fetching, if GitVersion does not calculate your version as expected you might need to allow fetching or use dynamic repositories  INFO [02/29/20 20:29:12:14] Creating local branch from remote tracking 'refs/remotes/origin/gitversion-beta'.  INFO [02/29/20 20:29:12:16] Creating local branch from remote tracking 'refs/remotes/origin/master'.  INFO [02/29/20 20:29:12:16] HEAD is detached and points at commit '57a682f6012d1f27255de86240fa98e87fe1f765'.  INFO [02/29/20 20:29:12:16] Local Refs:
2020-02-29T20:29:12.2345783Z refs/heads/gitversion-beta (e0722847c17cd9a98b2e5bbcd0443b09c254eb1e)
...
2020-02-29T20:29:12.2424071Z refs/tags/9.1.0 (6bdfd58ace86a6a3757766a18591fe4a54fcc356)  INFO [02/29/20 20:29:12:17] No local branch pointing at the commit '57a682f6012d1f27255de86240fa98e87fe1f765'. Fake branch needs to be created.  INFO [02/29/20 20:29:12:17] Fetching remote refs to see if there is a pull request ref  INFO [02/29/20 20:29:12:20] End: Normalizing git directory for branch '' (Took: 89.28ms)  ERROR [02/29/20 20:29:12:21] An unexpected error occurred:
2020-02-29T20:29:12.2424310Z LibGit2Sharp.LibGit2SharpException: this remote has never connected
2020-02-29T20:29:12.2424438Z    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
2020-02-29T20:29:12.2424569Z    at LibGit2Sharp.Core.Proxy.git_remote_ls(Repository repository, RemoteHandle remote)
2020-02-29T20:29:12.2424716Z    at LibGit2Sharp.Network.ListReferencesInternal(String url, CredentialsHandler credentialsProvider)
2020-02-29T20:29:12.2424935Z    at LibGit2Sharp.Network.ListReferences(Remote remote)
2020-02-29T20:29:12.2425130Z    at GitVersion.Helpers.GitRepositoryHelper.GetRemoteTipsForAnonymousUser(Repository repo, Remote remote) in D:\a\1\s\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 262
2020-02-29T20:29:12.2425301Z    at GitVersion.Helpers.GitRepositoryHelper.CreateFakeBranchPointingAtThePullRequestTip(ILog log, Repository repo, AuthenticationInfo authentication) in D:\a\1\s\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 201
2020-02-29T20:29:12.2425501Z    at GitVersion.Helpers.GitRepositoryHelper.NormalizeGitDirectory(ILog log, IEnvironment environment, String gitDirectory, AuthenticationInfo authentication, Boolean noFetch, String currentBranch, Boolean isDynamicRepository) in D:\a\1\s\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 111
2020-02-29T20:29:12.2425720Z    at GitVersion.GitPreparer.NormalizeGitDirectory(AuthenticationInfo auth, String targetBranch, String gitDirectory, Boolean isDynamicRepository) in D:\a\1\s\src\GitVersionCore\GitPreparer.cs:line 190
2020-02-29T20:29:12.2425888Z    at GitVersion.GitPreparer.Prepare(Boolean normalizeGitDirectory, String currentBranch, Boolean shouldCleanUpRemotes) in D:\a\1\s\src\GitVersionCore\GitPreparer.cs:line 65
2020-02-29T20:29:12.2426036Z    at GitVersion.GitVersionCalculator.CalculateVersionVariables() in D:\a\1\s\src\GitVersionCore\GitVersionCalculator.cs:line 54
2020-02-29T20:29:12.2426170Z    at GitVersion.ExecCommand.Execute() in D:\a\1\s\src\GitVersionExe\ExecCommand.cs:line 40
2020-02-29T20:29:12.2426338Z    at GitVersion.GitVersionExecutor.VerifyArgumentsAndRun(Arguments arguments) in D:\a\1\s\src\GitVersionExe\GitVersionExecutor.cs:line 117  INFO [02/29/20 20:29:12:21]   INFO [02/29/20 20:29:12:21] Attempting to show the current git graph (please include in issue):   INFO [02/29/20 20:29:12:21] Showing max of 100 commits
...

Linux raw logs from GitHub Actions captured after this change:

2020-02-29T20:42:14.4043485Z Executing: dotnet tool install "GitVersion.Tool" --tool-path "/home/runner/work/build-cake/build-cake/tools" --version 5.2.0-gh2139-1.351 --verbosity diagnostic
...
2020-02-29T20:43:18.3090344Z Executing: /home/runner/work/build-cake/build-cake/tools/dotnet-gitversion -output json -verbosity Debug
2020-02-29T20:43:18.7196502Z INFO [02/29/20 20:43:18:52] Applicable build agent found: 'GitHubActions'.
2020-02-29T20:43:18.7197972Z INFO [02/29/20 20:43:18:52] Working directory: /home/runner/work/build-cake/build-cake
2020-02-29T20:43:18.7199727Z INFO [02/29/20 20:43:18:52] IsDynamicGitRepository: False
2020-02-29T20:43:18.7200611Z INFO [02/29/20 20:43:18:54] Returning Project Root from DotGitDirectory: /home/runner/work/build-cake/build-cake/.git/ - /home/runner/work/build-cake/build-cake/
2020-02-29T20:43:18.7201038Z INFO [02/29/20 20:43:18:54] Running on Unix.
2020-02-29T20:43:18.7201660Z INFO [02/29/20 20:43:18:54] Applicable build agent found: 'GitHubActions'.
2020-02-29T20:43:18.7202056Z INFO [02/29/20 20:43:18:54] Branch from build environment: 
2020-02-29T20:43:18.7202674Z INFO [02/29/20 20:43:18:54] Begin: Normalizing git directory for branch ''
2020-02-29T20:43:18.7203320Z   INFO [02/29/20 20:43:18:56] One remote found (origin -> 'https://github.com/pharos/build-cake').
2020-02-29T20:43:18.7203719Z   INFO [02/29/20 20:43:18:57] Skipping fetching, if GitVersion does not calculate your version as expected you might need to allow fetching or use dynamic repositories
2020-02-29T20:43:18.7204337Z   INFO [02/29/20 20:43:18:58] Creating local branch from remote tracking 'refs/remotes/origin/gitversion-beta'.
2020-02-29T20:43:18.7204948Z   INFO [02/29/20 20:43:18:59] Creating local branch from remote tracking 'refs/remotes/origin/master'.
2020-02-29T20:43:18.7205610Z   INFO [02/29/20 20:43:18:59] HEAD is detached and points at commit 'c9d51bc9836a310145b3d8976a69b1859be36a35'.
2020-02-29T20:43:18.7205966Z   INFO [02/29/20 20:43:18:60] Local Refs:
2020-02-29T20:43:18.7206678Z refs/heads/gitversion-beta (885ddd88be9b7f339268c4cd43171d1e03d8cda4)
...
2020-02-29T20:43:18.7270721Z refs/tags/9.1.0 (6bdfd58ace86a6a3757766a18591fe4a54fcc356)
2020-02-29T20:43:18.7271145Z   INFO [02/29/20 20:43:18:60] No local branch pointing at the commit 'c9d51bc9836a310145b3d8976a69b1859be36a35'. Fake branch needs to be created.
2020-02-29T20:43:18.7271307Z   INFO [02/29/20 20:43:18:60] Fetching remote refs to see if there is a pull request ref
2020-02-29T20:43:18.7271665Z   INFO [02/29/20 20:43:18:66] End: Normalizing git directory for branch '' (Took: 124.33ms)
2020-02-29T20:43:18.7271807Z   ERROR [02/29/20 20:43:18:68] An unexpected error occurred:
2020-02-29T20:43:18.7272019Z LibGit2Sharp.LibGit2SharpException: this remote has never connected
2020-02-29T20:43:18.7272158Z    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
2020-02-29T20:43:18.7272293Z    at LibGit2Sharp.Core.Proxy.git_remote_ls(Repository repository, RemoteHandle remote)
2020-02-29T20:43:18.7272446Z    at LibGit2Sharp.Network.ListReferencesInternal(String url, CredentialsHandler credentialsProvider)
2020-02-29T20:43:18.7272583Z    at LibGit2Sharp.Network.ListReferences(Remote remote)
2020-02-29T20:43:18.7272741Z    at GitVersion.Helpers.GitRepositoryHelper.GetRemoteTipsForAnonymousUser(Repository repo, Remote remote) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 262
2020-02-29T20:43:18.7272926Z    at GitVersion.Helpers.GitRepositoryHelper.CreateFakeBranchPointingAtThePullRequestTip(ILog log, Repository repo, AuthenticationInfo authentication) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 201
2020-02-29T20:43:18.7273139Z    at GitVersion.Helpers.GitRepositoryHelper.NormalizeGitDirectory(ILog log, IEnvironment environment, String gitDirectory, AuthenticationInfo authentication, Boolean noFetch, String currentBranch, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 111
2020-02-29T20:43:18.7273340Z    at GitVersion.GitPreparer.NormalizeGitDirectory(AuthenticationInfo auth, String targetBranch, String gitDirectory, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 190
2020-02-29T20:43:18.7273536Z    at GitVersion.GitPreparer.Prepare(Boolean normalizeGitDirectory, String currentBranch, Boolean shouldCleanUpRemotes) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 65
2020-02-29T20:43:18.7273704Z    at GitVersion.GitVersionCalculator.CalculateVersionVariables() in C:\projects\gitversion\src\GitVersionCore\GitVersionCalculator.cs:line 52
2020-02-29T20:43:18.7273857Z    at GitVersion.ExecCommand.Execute() in C:\projects\gitversion\src\GitVersionExe\ExecCommand.cs:line 39
2020-02-29T20:43:18.7273998Z    at GitVersion.GitVersionExecutor.VerifyArgumentsAndRun(Arguments arguments) in C:\projects\gitversion\src\GitVersionExe\GitVersionExecutor.cs:line 119
2020-02-29T20:43:18.7274140Z   INFO [02/29/20 20:43:18:68] 
2020-02-29T20:43:18.7274272Z   INFO [02/29/20 20:43:18:68] Attempting to show the current git graph (please include in issue): 
2020-02-29T20:43:18.7274411Z   INFO [02/29/20 20:43:18:68] Showing max of 100 commits
...

Note that after the change I also forced a failure using GITHUB_REF="", since this version includes my previously merged fix to build GitHub PRs, and the logging in question is only shown upon failure.

As shown, the logging change had the desired effect and the GitVersion log is now much easier to read.

PS. It took me a while to find the AppVeyor NuGet feed at https://ci.appveyor.com/nuget/gitversion-8nigugxjftrw, needed to test with this PR. It should probably be documented somewhere?

Does not improve log readability. Prefer to keep vertical space compact.

gitfool · 2020-02-29T21:33:33Z

Check for "Build / Unit Test (macos-latest) (pull_request)" seems to have had an unrelated failure.

arturcic · 2020-03-01T10:23:01Z

Check for "Build / Unit Test (macos-latest) (pull_request)" seems to have had an unrelated failure.

Re-run the build, now it's fine

gitfool · 2020-03-02T00:17:37Z

Mac raw logs from GitHub Actions captured after this change:

2020-03-01T20:20:40.9431660Z Executing: dotnet tool install "GitVersion.Tool" --tool-path "/Users/runner/runners/2.165.2/work/build-cake/build-cake/tools" --version 5.2.0-gh2139-1.352 --verbosity diagnostic
...
2020-03-01T20:20:59.4018380Z Executing: /Users/runner/runners/2.165.2/work/build-cake/build-cake/tools/dotnet-gitversion -output json -verbosity Debug
2020-03-01T20:21:00.3159760Z INFO [03/01/20 20:20:59:72] Applicable build agent found: 'GitHubActions'.
2020-03-01T20:21:00.3161080Z INFO [03/01/20 20:20:59:73] Working directory: /Users/runner/runners/2.165.2/work/build-cake/build-cake
2020-03-01T20:21:00.3161720Z INFO [03/01/20 20:20:59:73] IsDynamicGitRepository: False
2020-03-01T20:21:00.3162950Z INFO [03/01/20 20:20:59:82] Returning Project Root from DotGitDirectory: /Users/runner/runners/2.165.2/work/build-cake/build-cake/.git/ - /Users/runner/runners/2.165.2/work/build-cake/build-cake/
2020-03-01T20:21:00.3163190Z INFO [03/01/20 20:20:59:82] Running on Unix.
2020-03-01T20:21:00.3163780Z INFO [03/01/20 20:20:59:82] Applicable build agent found: 'GitHubActions'.
2020-03-01T20:21:00.3164100Z INFO [03/01/20 20:20:59:82] Branch from build environment: 
2020-03-01T20:21:00.3164730Z INFO [03/01/20 20:20:59:82] Begin: Normalizing git directory for branch ''
2020-03-01T20:21:00.3165320Z   INFO [03/01/20 20:20:59:86] One remote found (origin -> 'https://github.com/pharos/build-cake').
2020-03-01T20:21:00.3165520Z   INFO [03/01/20 20:20:59:86] Skipping fetching, if GitVersion does not calculate your version as expected you might need to allow fetching or use dynamic repositories
2020-03-01T20:21:00.3166040Z   INFO [03/01/20 20:20:59:89] Creating local branch from remote tracking 'refs/remotes/origin/gitversion-beta'.
2020-03-01T20:21:00.3166700Z   INFO [03/01/20 20:20:59:93] Creating local branch from remote tracking 'refs/remotes/origin/master'.
2020-03-01T20:21:00.3167500Z   INFO [03/01/20 20:20:59:94] HEAD is detached and points at commit '0156dd4eefbb858d4252063ff7559b8e13d1bf6d'.
2020-03-01T20:21:00.3167630Z   INFO [03/01/20 20:20:59:96] Local Refs:
2020-03-01T20:21:00.3168210Z refs/heads/gitversion-beta (eeec48d1bc686176e46d1be7b1e85db1525d6169)
...
2020-03-01T20:21:00.3235330Z refs/tags/9.1.0 (6bdfd58ace86a6a3757766a18591fe4a54fcc356)
2020-03-01T20:21:00.3236360Z   INFO [03/01/20 20:20:59:97] No local branch pointing at the commit '0156dd4eefbb858d4252063ff7559b8e13d1bf6d'. Fake branch needs to be created.
2020-03-01T20:21:00.3236530Z   INFO [03/01/20 20:20:59:97] Fetching remote refs to see if there is a pull request ref
2020-03-01T20:21:00.3237090Z   INFO [03/01/20 20:21:00:16] End: Normalizing git directory for branch '' (Took: 330.74ms)
2020-03-01T20:21:00.3237220Z   ERROR [03/01/20 20:21:00:24] An unexpected error occurred:
2020-03-01T20:21:00.3237390Z LibGit2Sharp.LibGit2SharpException: this remote has never connected
2020-03-01T20:21:00.3237490Z    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
2020-03-01T20:21:00.3237600Z    at LibGit2Sharp.Core.Proxy.git_remote_ls(Repository repository, RemoteHandle remote)
2020-03-01T20:21:00.3237720Z    at LibGit2Sharp.Network.ListReferencesInternal(String url, CredentialsHandler credentialsProvider)
2020-03-01T20:21:00.3237830Z    at LibGit2Sharp.Network.ListReferences(Remote remote)
2020-03-01T20:21:00.3237970Z    at GitVersion.Helpers.GitRepositoryHelper.GetRemoteTipsForAnonymousUser(Repository repo, Remote remote) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 262
2020-03-01T20:21:00.3238120Z    at GitVersion.Helpers.GitRepositoryHelper.CreateFakeBranchPointingAtThePullRequestTip(ILog log, Repository repo, AuthenticationInfo authentication) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 201
2020-03-01T20:21:00.3238290Z    at GitVersion.Helpers.GitRepositoryHelper.NormalizeGitDirectory(ILog log, IEnvironment environment, String gitDirectory, AuthenticationInfo authentication, Boolean noFetch, String currentBranch, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 111
2020-03-01T20:21:00.3238460Z    at GitVersion.GitPreparer.NormalizeGitDirectory(AuthenticationInfo auth, String targetBranch, String gitDirectory, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 190
2020-03-01T20:21:00.3238620Z    at GitVersion.GitPreparer.Prepare(Boolean normalizeGitDirectory, String currentBranch, Boolean shouldCleanUpRemotes) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 65
2020-03-01T20:21:00.3238750Z    at GitVersion.GitVersionCalculator.CalculateVersionVariables() in C:\projects\gitversion\src\GitVersionCore\GitVersionCalculator.cs:line 52
2020-03-01T20:21:00.3238880Z    at GitVersion.ExecCommand.Execute() in C:\projects\gitversion\src\GitVersionExe\ExecCommand.cs:line 39
2020-03-01T20:21:00.3239080Z    at GitVersion.GitVersionExecutor.VerifyArgumentsAndRun(Arguments arguments) in C:\projects\gitversion\src\GitVersionExe\GitVersionExecutor.cs:line 119
2020-03-01T20:21:00.3239210Z   INFO [03/01/20 20:21:00:24] Attempting to show the current git graph (please include in issue): 
2020-03-01T20:21:00.3239320Z   INFO [03/01/20 20:21:00:24] Showing max of 100 commits
...

Windows raw logs from GitHub Actions captured after this change:

2020-03-02T00:06:37.8462530Z Executing: "dotnet" tool install "GitVersion.Tool" --tool-path "D:/a/build-cake/build-cake/tools" --version 5.2.0-gh2139-1.352 --verbosity diagnostic
...
2020-03-02T00:07:19.7109910Z Executing: "D:/a/build-cake/build-cake/tools/dotnet-gitversion.exe" -output json -verbosity Debug
2020-03-02T00:07:21.1462290Z INFO [03/02/20 0:07:19:94] Applicable build agent found: 'GitHubActions'.
2020-03-02T00:07:21.1559727Z INFO [03/02/20 0:07:19:94] Working directory: D:\a\build-cake\build-cake
2020-03-02T00:07:21.1567019Z INFO [03/02/20 0:07:19:95] IsDynamicGitRepository: False
2020-03-02T00:07:21.1567800Z INFO [03/02/20 0:07:19:97] Returning Project Root from DotGitDirectory: D:\a\build-cake\build-cake\.git\ - D:\a\build-cake\build-cake\
2020-03-02T00:07:21.1569118Z INFO [03/02/20 0:07:19:97] Running on Windows.
2020-03-02T00:07:21.1569857Z INFO [03/02/20 0:07:19:97] Applicable build agent found: 'GitHubActions'.
2020-03-02T00:07:21.1570926Z INFO [03/02/20 0:07:19:97] Branch from build environment: 
2020-03-02T00:07:21.1571499Z INFO [03/02/20 0:07:19:97] Begin: Normalizing git directory for branch ''
2020-03-02T00:07:21.1572540Z   INFO [03/02/20 0:07:20:01] One remote found (origin -> 'https://github.com/pharos/build-cake').
2020-03-02T00:07:21.1573075Z   INFO [03/02/20 0:07:20:02] Skipping fetching, if GitVersion does not calculate your version as expected you might need to allow fetching or use dynamic repositories
2020-03-02T00:07:21.1574160Z   INFO [03/02/20 0:07:20:05] Creating local branch from remote tracking 'refs/remotes/origin/gitversion-beta'.
2020-03-02T00:07:21.1574734Z   INFO [03/02/20 0:07:20:09] Creating local branch from remote tracking 'refs/remotes/origin/master'.
2020-03-02T00:07:21.1575731Z   INFO [03/02/20 0:07:20:09] HEAD is detached and points at commit '8fe8d477df6ed0083c36ca46ab23dff79c0057b5'.
2020-03-02T00:07:21.1576153Z   INFO [03/02/20 0:07:20:11] Local Refs:
2020-03-02T00:07:21.1577241Z refs/heads/gitversion-beta (f3ea29d391f0bdb91bcb6b7e2b4289fb2d603f96)
...
2020-03-02T00:07:21.1812816Z refs/tags/9.1.0 (6bdfd58ace86a6a3757766a18591fe4a54fcc356)
2020-03-02T00:07:21.1813574Z   INFO [03/02/20 0:07:20:12] No local branch pointing at the commit '8fe8d477df6ed0083c36ca46ab23dff79c0057b5'. Fake branch needs to be created.
2020-03-02T00:07:21.1814389Z   INFO [03/02/20 0:07:20:12] Fetching remote refs to see if there is a pull request ref
2020-03-02T00:07:21.1815113Z   INFO [03/02/20 0:07:20:26] End: Normalizing git directory for branch '' (Took: 288.54ms)
2020-03-02T00:07:21.1815770Z   ERROR [03/02/20 0:07:20:88] An unexpected error occurred:
2020-03-02T00:07:21.1817128Z LibGit2Sharp.LibGit2SharpException: this remote has never connected
2020-03-02T00:07:21.1817861Z    at LibGit2Sharp.Core.Ensure.HandleError(Int32 result)
2020-03-02T00:07:21.1818506Z    at LibGit2Sharp.Core.Proxy.git_remote_ls(Repository repository, RemoteHandle remote)
2020-03-02T00:07:21.1819324Z    at LibGit2Sharp.Network.ListReferencesInternal(String url, CredentialsHandler credentialsProvider)
2020-03-02T00:07:21.1820009Z    at LibGit2Sharp.Network.ListReferences(Remote remote)
2020-03-02T00:07:21.1823174Z    at GitVersion.Helpers.GitRepositoryHelper.GetRemoteTipsForAnonymousUser(Repository repo, Remote remote) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 262
2020-03-02T00:07:21.1824095Z    at GitVersion.Helpers.GitRepositoryHelper.CreateFakeBranchPointingAtThePullRequestTip(ILog log, Repository repo, AuthenticationInfo authentication) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 201
2020-03-02T00:07:21.1824977Z    at GitVersion.Helpers.GitRepositoryHelper.NormalizeGitDirectory(ILog log, IEnvironment environment, String gitDirectory, AuthenticationInfo authentication, Boolean noFetch, String currentBranch, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\Helpers\GitRepositoryHelper.cs:line 111
2020-03-02T00:07:21.1825890Z    at GitVersion.GitPreparer.NormalizeGitDirectory(AuthenticationInfo auth, String targetBranch, String gitDirectory, Boolean isDynamicRepository) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 190
2020-03-02T00:07:21.1826811Z    at GitVersion.GitPreparer.Prepare(Boolean normalizeGitDirectory, String currentBranch, Boolean shouldCleanUpRemotes) in C:\projects\gitversion\src\GitVersionCore\GitPreparer.cs:line 65
2020-03-02T00:07:21.1827571Z    at GitVersion.GitVersionCalculator.CalculateVersionVariables() in C:\projects\gitversion\src\GitVersionCore\GitVersionCalculator.cs:line 52
2020-03-02T00:07:21.1828230Z    at GitVersion.ExecCommand.Execute() in C:\projects\gitversion\src\GitVersionExe\ExecCommand.cs:line 39
2020-03-02T00:07:21.1829049Z    at GitVersion.GitVersionExecutor.VerifyArgumentsAndRun(Arguments arguments) in C:\projects\gitversion\src\GitVersionExe\GitVersionExecutor.cs:line 119
2020-03-02T00:07:21.1829892Z   INFO [03/02/20 0:07:20:88] Attempting to show the current git graph (please include in issue): 
2020-03-02T00:07:21.1830838Z   INFO [03/02/20 0:07:20:88] Showing max of 100 commits
...

asbjornu

LGTM!

asbjornu · 2020-03-02T10:09:37Z

Thanks for your contributions, @gitfool! 🙏

gitfool added 4 commits February 29, 2020 13:50

Fix log write to append line

b08853b

Fix newlines to be platform agnostic

656d194

Supress CS0618 build warning for known obsolete members

9beb51a

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0618

Suppress NU1701 build warning for Microsoft.Build package

6ef576d

https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1701

arturcic requested a review from asbjornu February 29, 2020 05:51

arturcic added the improvement label Feb 29, 2020

arturcic added this to the 5.2.0 milestone Feb 29, 2020

Remove redundant line separator

1d16eed

Does not improve log readability. Prefer to keep vertical space compact.

asbjornu approved these changes Mar 2, 2020

View reviewed changes

asbjornu merged commit 7c4b172 into GitTools:master Mar 2, 2020

gitfool deleted the gh2139 branch March 2, 2020 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH2139: GitVersion logging does not include newlines #2146

GH2139: GitVersion logging does not include newlines #2146

Uh oh!

gitfool commented Feb 29, 2020 •

edited

Loading

Uh oh!

gitfool commented Feb 29, 2020 •

edited

Loading

Uh oh!

gitfool commented Feb 29, 2020

Uh oh!

arturcic commented Mar 1, 2020

Uh oh!

gitfool commented Mar 2, 2020

Uh oh!

asbjornu left a comment

Uh oh!

asbjornu commented Mar 2, 2020

Uh oh!

Uh oh!

GH2139: GitVersion logging does not include newlines #2146

GH2139: GitVersion logging does not include newlines #2146

Uh oh!

Conversation

gitfool commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitfool commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitfool commented Feb 29, 2020

Uh oh!

arturcic commented Mar 1, 2020

Uh oh!

gitfool commented Mar 2, 2020

Uh oh!

asbjornu left a comment

Choose a reason for hiding this comment

Uh oh!

asbjornu commented Mar 2, 2020

Uh oh!

Uh oh!

gitfool commented Feb 29, 2020 •

edited

Loading

gitfool commented Feb 29, 2020 •

edited

Loading