Skip to content

Encourage writing RepositoryFixture tests #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

asbjornu
Copy link
Member

I think it's a good idea to encourage writing RepositoryFixture tests in the bug and feature request templates.

Description

Add text to the bug and feature request templates encouraging the submission of RepositoryFixture tests so contributors are made aware of their existence and can see how easy they are to write.

Motivation and Context

RepositoryFixture tests are a great, precise, canonical way to describe the behavior expected from GitVersion.

@asbjornu asbjornu requested a review from arturcic May 27, 2020 10:12
Copy link
Member

@arturcic arturcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@arturcic
Copy link
Member

@asbjornu merge it when the CI is ready

@asbjornu asbjornu merged commit 791f284 into GitTools:master May 27, 2020
@asbjornu asbjornu deleted the feature/encourage-repository-fixture-tests branch May 27, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants