Allows usage of Web SDK when updating project files #2291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
approved these changes
May 27, 2020
|
Thanks for the lovely cat picture! And also for your code contributions, but mostly for the picture of your cat. 😸 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a use-case I missed in the previous feature. Ironically enough I was motivated to contribute here specifically to have Azure CI builds use GitVersion to update my web project, and I missed it. Meh.
Description
Allows project file updating for Web SDK Projects
Related Issue
Fixes #2290
Motivation and Context
I'd like to update my ASP.NET Core projects.
How Has This Been Tested?
Added a test to ensure the
Microsoft.NET.Sdk.Webwas an allowed SDKScreenshots (if appropriate):
None. But you may have a picture of another one of my cats.
Checklist: