Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the following properties from
Int32
to toInt64
to avoidSystem.OverflowException
onint.Parse()
of very large numbers:SemanticVersion.Major
SemanticVersion.Minor
SemanticVersion.Patch
SemanticVersionBuildMetaData.CommitsSinceTag
SemanticVersionBuildMetaData.CommitsSinceVersionSource
SemanticVersionBuildMetaData.UncommittedChanges
SemanticVersionPreReleaseTag.Number
Related Issue
Fixes #2715.
Fixes #2915.
Fixes #2390.
Motivation and Context
Large numbers in a version number may cause the following lines to throw a
System.OverflowException
:GitVersion/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersion.cs
Lines 171 to 173 in 3297736
GitVersion/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionBuildMetaData.cs
Line 127 in 3297736
GitVersion/src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs
Line 79 in 3297736
How Has This Been Tested?
I've added test cases that failed before the code changes were implemented.
Checklist: