Better switching to git flow story #308
Conversation
|
@SimonCropp @andreasohlund @gep13 would love a review on this too |
|
Out at a wedding today/tonight but will try and have a look tomorrow. Sent from my Windows Phone From: Jake Ginnivanmailto:[email protected] @SimonCropp @andreasohlund @gep13 would love a review on this too Reply to this email directly or view it on GitHub: |
|
why the removal of short version. i thought that concept was a good way of avoiding accidents of thinking you were dealing with a full semver in scenarios where that was actually not possible |
|
The issue is that we are using it to store git tags, which breaks for 4 part versions and git tags which have pre-release tags. Seemed like it got in the way and while we may have additional information floating around at some points we create a new Semantic Version in each of the different version finders taking the bits we actually care about. |
|
Ok fair enough. Everything else looks good |
|
I'm rebasing now. Another motivation is to simplify, we could reintroduce but make it a wrapper for SemanticVersion which hides information rather than another type/parser etc |
|
Nah lets not sweat the wrapper. Let go with this for now. In theory if we have good enough integrations tests it should be a non issue |
|
Yeah, that is what I thought. Hence the other PR, I think coverage is getting pretty good now |
JakeGinnivan
force-pushed
the
BetterSwitchingToGitFlowStory
branch
from
dc42b20 to
5d55a34
Compare
|
Rebased |
Better switching to git flow story
Fixes #296