Skip to content

Ensuring intermediate output path exists #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022

Conversation

jpeirson
Copy link

@jpeirson jpeirson commented May 10, 2022

Fixes #2815

When generating the GitVersionInformation.g.cs file, checks that the IntermediateOutputPath exists before attempting to write the file.

Description

Added CreateDirectory() when calling GenerateGitVersionInformation task.

Related Issue

#2815

Motivation and Context

Fixes above issue, which I'm able to reproduce in my own project.

How Has This Been Tested?

  • Unit tests
  • Run against sample project from issue

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. --> no
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic
Copy link
Member

@jpeirson can you fix it in the same way the UpdateAssemblyInfo task as well?

@jpeirson
Copy link
Author

@arturcic done.

@arturcic
Copy link
Member

@arturcic arturcic merged commit 7a635bd into GitTools:support/5.x May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

Thank you @jpeirson for your contribution!

@jpeirson jpeirson deleted the bugfix/issue-2815 branch May 12, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dotnet pack fails on cold build with GitVersion.MsBuild and IsPackable=false
2 participants