Use defined project intermediate directory if it exists

[bdhess]

Fixes #332

[gep13]

@SimonCropp when you have a second, can you take a look at this one? Thanks!

[grufffta]

I think you have deleted some code that checks if the ProjectDir (now IntermediateOutputPath) is null and tracks the temporary file. In the tests a Mock is used so the variables are not set.

Think it should be

void CreateTempAssemblyInfo(CachedVersion semanticVersion, Config configuration)
        {
            var assemblyInfoBuilder = new AssemblyInfoBuilder
                                      {
                                          CachedVersion = semanticVersion
                                      };
            var assemblyInfo = assemblyInfoBuilder.GetAssemblyInfoText(configuration);

            string tempFileName, tempDir;
            if (string.IsNullOrEmpty(IntermediateOutputPath) || string.IsNullOrWhiteSpace(IntermediateOutputPath))
            {
                tempDir = TempFileTracker.TempPath;
                tempFileName = string.Format("AssemblyInfo_{0}_{1}.g.cs", Path.GetFileNameWithoutExtension(ProjectFile), Path.GetRandomFileName());
            }
            else
            {
                tempDir = Path.Combine(IntermediateOutputPath, "obj", Configuration);
                Directory.CreateDirectory(tempDir);
                tempFileName = string.Format("GitVersionTaskAssemblyInfo.g.cs");
            }

            AssemblyInfoTempFilePath = Path.Combine(tempDir, tempFileName);
            File.WriteAllText(AssemblyInfoTempFilePath, assemblyInfo);
        }

Thanks
Gareth

[SimonCropp]

echoing the comment by @grufffta . @bdhess was that intentional?

[bdhess]

Sorry about that, and for the delay getting back to this.
@grufffta @SimonCropp - ready for another look? The build appears to be clean now. And thanks!

[JakeGinnivan]

This looks ok to me, but looks like a breaking change. @SimonCropp thoughts?

[SimonCropp]

Yeah in the strict sense this is breaking change

[JakeGinnivan]

Do we care?

Should we take this into v3 which has the config changes and other breaking stuff. Or just merge and put into next minor release?

[SimonCropp]

i think next minor is OK. i doubt many people are using the task on its own. and even if they do it will fail at buid time